Adding vertical content alignment control.#684
Merged
tsipinakis merged 4 commits intodunst-project:masterfrom Jan 30, 2020
chronus7:master
Merged
Adding vertical content alignment control.#684tsipinakis merged 4 commits intodunst-project:masterfrom chronus7:master
tsipinakis merged 4 commits intodunst-project:masterfrom
chronus7:master
Conversation
This adds the option `content_alignment`, which allows the user to set the vertical alignment of the notification's content (i.e. icon and text) to either top (`CONTENT_TOP`), center (`CONTENT_CENTER`, default), or bottom (`CONTENT_BOT`). The default preserves current behaviour, while the other options fulfill #486.
Member
|
Thanks for adding this! I'm a bit busy at the moment, you can expect a review around Wednesday. From a very quick glance you also need to add the new setting to the |
Contributor
Author
Sure, no stress. :)
Ah, makes sense. I will look into it and update accordingly. |
tsipinakis
reviewed
Jan 29, 2020
Member
tsipinakis
left a comment
tsipinakis
left a comment
There was a problem hiding this comment.
I am open to any suggestions or comments regarding [..] code-style.
Since you mentioned that I'll leave in some of the code-style nitpicks :)
Other than the few small notes this looks good, couldn't find a way to break it 👍
- adding default to config.h#defaults - changing naming from content_* to vertical_* - replacing switch-case with if-else-if
tsipinakis
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the option
content_alignment, which allows the user to set the vertical alignment of the notification's content (i.e. icon andtext) to either:
CONTENT_TOP),CONTENT_CENTER, default), orCONTENT_BOT).The default preserves current behaviour, while the other options fulfill #486.
I am open to any suggestions or comments regarding naming and/or code-style.