Set environment variables for scripts #802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 59.48% 59.64% +0.16%
==========================================
Files 36 36
Lines 5800 5880 +80
==========================================
+ Hits 3450 3507 +57
- Misses 2350 2373 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fwsmit
force-pushed
the
environment-variables
branch
2 times, most recently
from
6e5ebfd to
38ed1d3
Compare
|
Turns out, setenv can block if you feed it NULL. So I made a safe setenv function to prevent that. Also added some documentation. |
fwsmit
force-pushed
the
environment-variables
branch
4 times, most recently
from
dddb51e to
ac6f1fd
Compare
|
I added the icon path function to this pr as well. Tests fail, because the old behaviour of the pixbuf creation was to continue searching the icon path when an invalid icon was found. This behaviour changed to returning the path to the invalid icon, thus not being able to create the pixbuf. |
fwsmit
force-pushed
the
environment-variables
branch
from
ac6f1fd to
beaba34
Compare
|
CI appears to be failing now. |
See #802 (comment) |
Whoops, that should teach me to review code at 1 am 🙈 That's fine, I don't expect that there will be many invalid icons and, but please fix the tests :) |
fwsmit
force-pushed
the
environment-variables
branch
2 times, most recently
from
24b3e8d to
0486ca5
Compare
I also fixed a test that was broken because of different behaviour. Now the first icon path is returned instead of the first valid icon path.
fwsmit
force-pushed
the
environment-variables
branch
from
0486ca5 to
bc3de38
Compare
|
I forgive you :). The tests should now be fixed |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
4 participants
Addresses #767 and #653. This PR sets environment variables for scripts to use. Let me know if I have to add more or if the naming should be changed. I still need to do the documentation, but I wanted to get some comments before that.