Skip to content

Redesigning the window geometry/dimension settings #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fwsmit merged 12 commits into from
Sep 22, 2021
Merged

Redesigning the window geometry/dimension settings #855

fwsmit merged 12 commits into from
Sep 22, 2021

Conversation

@fwsmit
Copy link
Member

@fwsmit fwsmit commented Apr 22, 2021 •
edited
Loading

This PR implements #336, building on top of settings refactor v2
See #336 (comment) for a description of the latest idea
Fixes #336 #82 #233
Seems to fix #518

@fwsmit fwsmit force-pushed the change-settings branch from e4b8948 to 3e1b306 Compare May 2, 2021 11:16
@fwsmit fwsmit mentioned this pull request Jun 21, 2021
Closed
This was referenced Jul 2, 2021
Closed
Merged
@fwsmit fwsmit force-pushed the change-settings branch from 3e1b306 to 13c5b46 Compare July 7, 2021 16:38
@fwsmit fwsmit force-pushed the change-settings branch 4 times, most recently from 4eb74e9 to 8179bfb Compare July 29, 2021 20:44
@fwsmit fwsmit marked this pull request as ready for review July 29, 2021 20:48
@fwsmit
Copy link
Member Author

fwsmit commented Jul 29, 2021

Weird. No CI is running in this PR anymore

@fwsmit fwsmit closed this Jul 29, 2021
@fwsmit fwsmit reopened this Jul 29, 2021
@fwsmit fwsmit closed this Jul 29, 2021
@fwsmit fwsmit reopened this Jul 29, 2021
@fwsmit
Copy link
Member Author

fwsmit commented Jul 29, 2021

It somehow works again. Sorry for extra PR

@fwsmit fwsmit mentioned this pull request Jul 29, 2021
Closed
@fwsmit fwsmit force-pushed the change-settings branch from ab54679 to 54ff1c7 Compare July 29, 2021 21:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021 •
edited
Loading

Codecov Report

Merging #855 (7bb700c) into master (ad352f9) will increase coverage by 0.77%.
The diff coverage is 57.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
+ Coverage   60.18%   60.96%   +0.77%     
==========================================
  Files          39       39              
  Lines        6181     6340     +159     
==========================================
+ Hits         3720     3865     +145     
- Misses       2461     2475      +14
Flag Coverage Δ
unittests 60.96% <57.26%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/draw.c 0.97% <0.00%> (+0.05%) ⬆️
src/wayland/wl.c 0.00% <0.00%> (ø)
src/x11/x.c 0.00% <0.00%> (-2.22%) ⬇️
test/setting.c 96.55% <0.00%> (-0.60%) ⬇️
test/settings_data.c 96.90% <ø> (ø)
src/option_parser.c 80.82% <70.70%> (-3.06%) ⬇️
src/queues.c 91.49% <75.00%> (+0.44%) ⬆️
src/utils.c 90.42% <86.66%> (-0.38%) ⬇️
src/settings.c 63.63% <100.00%> (+7.11%) ⬆️
test/option_parser.c 98.94% <100.00%> (+0.12%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad352f9...7bb700c. Read the comment docs.

@fwsmit fwsmit force-pushed the change-settings branch 2 times, most recently from 5da8de6 to 0755c6b Compare August 30, 2021 15:16
@fwsmit fwsmit mentioned this pull request Sep 10, 2021
Merged
@fwsmit fwsmit marked this pull request as draft September 13, 2021 14:39
@fwsmit fwsmit marked this pull request as ready for review September 17, 2021 18:36
This was referenced Sep 17, 2021
Closed
Closed
@etrnal70
Copy link

etrnal70 commented Sep 18, 2021

Just tried this PR today. Is the offset setting broken ? Because I don't see any change when set it with any value. I'm using wayland on sway

etrnal70
etrnal70 reviewed Sep 19, 2021
View reviewed changes
@etrnal70
Copy link

etrnal70 commented Sep 19, 2021

image

Shouldn't hidden notification only show hidden count ? (No icon and progress bar)

@fwsmit
Copy link
Member Author

fwsmit commented Sep 21, 2021 •
edited
Loading

image

Shouldn't hidden notification only show hidden count ? (No icon and progress bar)

I'll consider this a separate issue. While investigating this, I also noticed that the timeout of the hidden notifications is also ignored.
Edit: created an issue: #915

@fwsmit
Copy link
Member Author

fwsmit commented Sep 21, 2021

Thanks for testing @etrnal70. I'll go ahead and merge this soon.

etrnal70
etrnal70 reviewed Sep 21, 2021
View reviewed changes
@fwsmit fwsmit merged commit f83f856 into dunst-project:master Sep 22, 2021
@fwsmit fwsmit deleted the change-settings branch September 22, 2021 08:49
@WhyNotHugo WhyNotHugo mentioned this pull request Sep 22, 2021
Closed
@fwsmit fwsmit mentioned this pull request Sep 22, 2021
Closed
fitrh added a commit to fitrh/dotfiles that referenced this pull request Sep 26, 2021
@fitrh
config/dunst: Remove geometry settings, upstream follow up
d46e9ce 
ref: dunst-project/dunst#855
@fwsmit fwsmit mentioned this pull request Sep 28, 2021
Closed
cdown added a commit to cdown/dotfiles that referenced this pull request Oct 22, 2021
@cdown
dunst: Update geometry settings for 1.7.0
26e8717 
See dunst-project/dunst#855.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@etrnal70 etrnal70 etrnal70 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not correctly wrapping text with shrink enabled. Redesigning the window geometry/dimension settings

3 participants

@fwsmit @codecov-commenter @etrnal70