Skip to content

Add word wrap in again#937

Merged
fwsmit merged 4 commits intodunst-project:masterfrom
fwsmit:add_word_wrap
Oct 18, 2021
Merged

Add word wrap in again#937
fwsmit merged 4 commits intodunst-project:masterfrom
fwsmit:add_word_wrap

Conversation

@fwsmit
Copy link
Copy Markdown
Member

@fwsmit fwsmit commented Oct 17, 2021

This time it's a rule. I changed ellipsize and alignment to a rule as well.
You don't need to change anything to your config, since you can also use rules in the [global] section now. But if you want, you can turn off word_wrap just word just for the notifications that need it.

@fitrh or @wael444 would you mind checking if this matches the desired behaviour?

fixes #921

@fitrh
Copy link
Copy Markdown

fitrh commented Oct 18, 2021

Cool, nice idea to have them as rules, and yes, it is.

word_wrap=false, ellipsize=middle

ellipsize=middle

word_wrap=false, ellipsize=end

ellipsize=end

@fwsmit
Copy link
Copy Markdown
Member Author

fwsmit commented Oct 18, 2021

Great, thanks for testing

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 18, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.11%. Comparing base (660fdba) to head (15e737d).
⚠️ Report is 788 commits behind head on master.

Files with missing lines Patch % Lines
src/draw.c 0.00% 7 Missing ⚠️
src/rules.c 75.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
+ Coverage   60.00%   60.11%   +0.10%     
==========================================
  Files          42       42              
  Lines        6434     6434              
==========================================
+ Hits         3861     3868       +7     
+ Misses       2573     2566       -7     
Flag Coverage Δ
unittests 60.11% <52.63%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fwsmit fwsmit merged commit 151d2c1 into dunst-project:master Oct 18, 2021
@fwsmit fwsmit deleted the add_word_wrap branch October 18, 2021 20:54
fitrh added a commit to fitrh/dotfiles that referenced this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

word_wrap setting stops working

3 participants