notification_height seems deprecated, edit changelog and manpage#943
Closed
flyxyz123 wants to merge 1 commit into
Closed
notification_height seems deprecated, edit changelog and manpage#943flyxyz123 wants to merge 1 commit into
flyxyz123 wants to merge 1 commit into
Conversation
flyxyz123
changed the title
Codecov Report
@@ Coverage Diff @@
## master #943 +/- ##
=======================================
Coverage 60.09% 60.09%
=======================================
Files 42 42
Lines 6438 6438
=======================================
Hits 3869 3869
Misses 2569 2569
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
fwsmit
requested changes
Oct 23, 2021
fwsmit
left a comment
fwsmit
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. notification_height is indeed deprecated.
Member
|
Thanks again! This branch is merged in 4301ac1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.