Fix 'icon_position = off' not being respected

[milaq]

Hey again,

noticed today that my notifications looked all wonky with a huge icon on the right side.

Turns out that with 0b1cf92 the icon_position was not being evaluated correctly.
The check for icon_position = off was patched out with no replacement (settings.icon_position != ICON_OFF && n->icon).
This commit fixes this by reapplying the needed checks.

Maybe the tests in https://github.com/dunst-project/dunst/blob/master/test/notification.c need some adjustment for ICON_OFF to catch issues with this next time.

Best regards,
Michael

[codecov-commenter]

Codecov Report

Merging #996 (9a599b9) into master (c909848) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
- Coverage   60.14%   60.12%   -0.02%     
==========================================
  Files          44       44              
  Lines        6789     6791       +2     
==========================================
  Hits         4083     4083              
- Misses       2706     2708       +2     

Flag	Coverage Δ
unittests	60.12% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/draw.c	0.94% <0.00%> (-0.01%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c909848...9a599b9. Read the comment docs.

[fwsmit]

Thanks, I completely missed that indeed. I'll add some tests to make sure that doesn't happen again :)

[milaq]

Sounds good. Thanks for the swift merge!