Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Deprecate list module specification in BadNameAttributeUseLinter #20

Closed
mschwager opened this issue Sep 17, 2019 · 1 comment
Closed

Comments

@mschwager
Copy link
Collaborator

Subclasses that implement BadNameAttributeUseLinter currently must specify:

{
    "object_attribute": [
        ["module_name1", "module_name2"],
        ["module_name3", "module_name4"],
    ]
}

To migrate toward our new "module path" concept we should use module path strings instead of lists, e.g.

{
    "object_attribute": [
        "module_name1.module_name2",
        "module_name3.module_name4",
    ]
}

This will make our interfaces take similar objects to specify similar concepts. E.g. specifying a fully-formed module as 'mod1.mod2.mod3.attr' instead of ['mod1', 'mod2', 'mod3', 'attr'].

@mschwager
Copy link
Collaborator Author

This should also include ensuring that fully-formed module paths are being passed. This will probably require a Namespace to be passed in when comparing modules and attributes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant