Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded dependency #58

Merged
merged 4 commits into from Jan 2, 2020
Merged

Removed unneeded dependency #58

merged 4 commits into from Jan 2, 2020

Conversation

@jordan-wright
Copy link
Contributor

jordan-wright commented Dec 24, 2019

This commit removes the unnecessary github.com/katzenpost/core dependency. We were only
using this library for a few helper functions, which are trivially implemented using
the standard library. I also added some tests to confirm these changes.

This also has the side effect of fixing our broken implementation of DisplayPublicKey
for OKPs, since the initial implementation sent the public key bytes to the ToPEMFile
function which expected a filename.

I've updated go.mod and go.sum using "go mod tidy" to reflect the new changes.

Fixes #56

This commit removes the unnecessary github.com/katzenpost/core dependency. We were only
using this library for a few helper functions, which are trivially implemented using
the standard library. I also added some tests to confirm these changes.

This also has the side effect of fixing our broken implementation of DisplayPublicKey
for OKPs, since the initial implementation sent the public key bytes to the `ToPEMFile`
function which expected a filename.

I've updated go.mod and go.sum using "go mod tidy" to reflect the new changes.
@jordan-wright jordan-wright requested a review from nicksteele Dec 24, 2019
On further review, it appears that support for Ed25519 public keys in
MarshalPKIXPublicKey was added in Go 1.13. I backported the changes so that we
can continue to support older versions of Go.

I also updated the Travis CI job to run tests on the latest versions of Go.
@jordan-wright

This comment has been minimized.

Copy link
Contributor Author

jordan-wright commented Dec 24, 2019

On further review, it appears that support for Ed25519 public keys in
x509.MarshalPKIXPublicKey was added in Go 1.13. I backported the changes so that we
can continue to support older versions of Go.

It's worth noting that in webauthncose.go, I'm using golang.org/x/crypto/ed25519. In Go 1.13 and above, this is just a wrapper for crypto/ed25519. Eventually once Go 1.13 is the lowest version we want to support, we can update this.

I also updated the Travis CI job to run tests on the latest versions of Go.

@nicksteele nicksteele merged commit b6f4116 into master Jan 2, 2020
2 of 3 checks passed
2 of 3 checks passed
Build Failed Build Failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jordan-wright jordan-wright deleted the 56-remove-dependency branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.