From e0985d6d073b1ad4f08a7601117a16a2a7107445 Mon Sep 17 00:00:00 2001
From: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Date: Thu, 18 Jul 2019 18:51:12 -0300
Subject: [PATCH] [JBPM-8549] - Onboarding readme knative instructions update
 (#48)

---
 onboarding-example/hr/readme.md         |  4 ++--
 onboarding-example/onboarding/readme.md | 13 ++++++++++---
 onboarding-example/payroll/readme.md    |  4 ++--
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/onboarding-example/hr/readme.md b/onboarding-example/hr/readme.md
index 351be9702c4..d7981db0960 100644
--- a/onboarding-example/hr/readme.md
+++ b/onboarding-example/hr/readme.md
@@ -76,14 +76,14 @@ NOTE: Make sure that kogito S2I image builders are available to your OpenShift e
 * Create new binary build and start it by uploading content of the current directory
 
 ```sh
-oc new-build myproject/kaas-quarkus-centos-s2i --binary=true --name=hr-service-builder
+oc new-build myproject/kogito-quarkus-centos-s2i --binary=true --name=hr-service-builder
 oc start-build hr-service-builder --from-dir . --incremental=true
 ```
 
 Once the build is completed create new build for runtime image
 
 ```sh
-oc new-build --name hr-service --source-image=hr-service-builder --source-image-path=/home/kogito/bin:. --image-stream=kaas-quarkus-centos
+oc new-build --name hr-service --source-image=hr-service-builder --source-image-path=/home/kogito/bin:. --image-stream=kogito-quarkus-centos
 ```
 
 Next create application for the runtime image
diff --git a/onboarding-example/onboarding/readme.md b/onboarding-example/onboarding/readme.md
index cb12a9c5b22..988f903459c 100644
--- a/onboarding-example/onboarding/readme.md
+++ b/onboarding-example/onboarding/readme.md
@@ -60,14 +60,14 @@ NOTE: Make sure that kogito S2I image builders are available to your OpenShift e
 * Create new binary build and start it by uploading content of the current directory
 
 ```sh
-oc new-build myproject/kaas-quarkus-centos-s2i --binary=true --name=onboarding-service-builder
+oc new-build myproject/kogito-quarkus-centos-s2i --binary=true --name=onboarding-service-builder
 oc start-build onboarding-service-builder --from-dir . --incremental=true
 ```
 
 Once the build is completed create new build for runtime image
 
 ```sh
-oc new-build --name onboarding-service --source-image=onboarding-service-builder --source-image-path=/home/kogito/bin:. --image-stream=kaas-quarkus-centos
+oc new-build --name onboarding-service --source-image=onboarding-service-builder --source-image-path=/home/kogito/bin:. --image-stream=kogito-quarkus-centos
 ```
 
 Next create application for the runtime image
@@ -107,5 +107,12 @@ service discovery can properly happen
 
 ```sh
 oc policy add-role-to-group view system:serviceaccounts:default -n istio-system
- oc policy add-role-to-group knative-serving-core system:serviceaccounts:default -n default
+oc policy add-role-to-group knative-serving-core system:serviceaccounts:default -n default
+```
+
+If using [Knative Serving Operator](https://github.com/knative/serving-operator) on OpenShift 4.x, the permissions that need to be set are
+
+```sh
+oc adm policy add-role-to-user knative-serving-core system:serviceaccount:myproject:default -n default
+oc adm policy add-role-to-user view system:serviceaccount:myproject:default -n istio-system    
 ```
\ No newline at end of file
diff --git a/onboarding-example/payroll/readme.md b/onboarding-example/payroll/readme.md
index 02a3a0cb719..0d5aad14a33 100644
--- a/onboarding-example/payroll/readme.md
+++ b/onboarding-example/payroll/readme.md
@@ -80,14 +80,14 @@ NOTE: Make sure that kogito S2I image builders are available to your OpenShift e
 * Create new binary build and start it by uploading content of the current directory
 
 ```sh
-oc new-build myproject/kaas-quarkus-centos-s2i --binary=true --name=payroll-service-builder
+oc new-build myproject/kogito-quarkus-centos-s2i --binary=true --name=payroll-service-builder
 oc start-build payroll-service-builder --from-dir . --incremental=true
 ```
 
 Once the build is completed create new build for runtime image
 
 ```sh
-oc new-build --name payroll-service --source-image=payroll-service-builder --source-image-path=/home/kogito/bin:. --image-stream=kaas-quarkus-centos
+oc new-build --name payroll-service --source-image=payroll-service-builder --source-image-path=/home/kogito/bin:. --image-stream=kogito-quarkus-centos
 ```
 
 Next create application for the runtime image