Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backends are not disposed after upload operations #3808

Closed
warwickmm opened this issue Jul 6, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@warwickmm
Copy link
Contributor

commented Jul 6, 2019

Environment info

  • Duplicati version: 2.0.4.16
  • Operating system: All
  • Backend: All

Description

It appears that the backends are not disposed after their use in upload operations. Previously, their disposal was managed by the BackendHandler instance. However, after pull request #3684, this instance is no longer used, and it looks like we forgot to ensure that the backends are disposed after their use. One approach may be to make each Worker implement the IDisposable interface (each Worker contains an instance of an IBackend).

There is a related forum discussion here, where a user noticed that SFTP connections were not being closed and a maximum connection limit was being reached.

@warwickmm warwickmm added the bug label Jul 6, 2019

@warwickmm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

I can see with the SFTP backend that connections remain open after an upload has completed.

@warwickmm warwickmm added the reproduced label Jul 6, 2019

warwickmm added a commit to warwickmm/duplicati that referenced this issue Jul 6, 2019

@Pectojin

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Closed by #3809

@Pectojin Pectojin closed this Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.