Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative ftp backend #1690

Merged
merged 6 commits into from Apr 10, 2016

Conversation

Projects
None yet
4 participants
@mylemans
Copy link
Contributor

commented Apr 9, 2016

Implemented an alternative FTP backend using System.Net.FtpClient

tmylemans-aim added some commits Apr 9, 2016

@kenkendk

This comment has been minimized.

Copy link
Member

commented Apr 9, 2016

Overall: good job!

Minor thing: There is a lot of whitespace changes that makes it hard to review the changes. What editor have you used?

I am not sure what the changes to the solution file formatting options do?
Also, is there a reason that the solution file format version was updated?

The LICENSE.TXT is called license.txt in the other projects, I can't remember if the name is used for anything. The Debug folder under the thirdparty library is not required. For debugging, developers should just download it.

The code looks like a copy of the original FTP implementation, would it make sense to re-use some things, e.g. The List command parsing logic?

@mylemans

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2016

@kenkendk Take a closer look, it does its own parsing (not custom), it is not using the logic from the base FTP backend.

And I used VS2015 Community Edition.

@kenkendk

This comment has been minimized.

Copy link
Member

commented Apr 10, 2016

Yes, I see, I remembered the list parsing wrong.
I have cleaned a few things, and will merge from this branch:
https://github.com/duplicati/duplicati/tree/feature/mylemans-alternative_ftp_backend

@kenkendk kenkendk merged commit 5bf6b7f into duplicati:master Apr 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@duplicatibot

This comment has been minimized.

Copy link

commented Jul 8, 2019

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/problems-after-upgrade-to-2-0-4-21/7469/11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.