New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default filters in server / UI #3023

Merged
merged 1 commit into from Feb 10, 2018

Conversation

Projects
None yet
3 participants
@tygill
Contributor

tygill commented Feb 9, 2018

When running a backup via the web UI, filters are loaded from the database instead of from the options, which means that the default filters aren't taken into account.

This change updates the ApplyFilter method used by the Server's Runner method to search for the default filters option, and append those filters to the list if they are found.
This should support both global and per-backup settings for default filters, as it checks the options after the two are merged.

This is the actual fix for #3015. (It should also resolve #2495, which looks like an old bug about excluding $RECYCLE.BIN and 'System Volume Information' by default.)

When running a backup via the GUI, filters are loaded from the databa…
…se instead of from the options, which means that the default filters aren't taken into account.

This change updates the ApplyFilter method used by the Server's Runner method to search for the default filters option, and append those filters to the list if they are found.
This should support both global and per-backup settings for default filters, as it checks the options after the two are merged.

@kenkendk kenkendk merged commit 3452aaa into duplicati:master Feb 10, 2018

2 of 3 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tygill tygill deleted the tygill:fix/default-filters-gui branch Feb 12, 2018

@duplicatibot

This comment has been minimized.

duplicatibot commented Feb 12, 2018

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/release-2-0-2-19-canary-2018-02-12/2455/9

@duplicatibot

This comment has been minimized.

duplicatibot commented Feb 12, 2018

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/release-2-0-2-19-canary-2018-02-12/2455/11

@duplicatibot

This comment has been minimized.

duplicatibot commented Feb 12, 2018

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/should-2-0-2-19-be-promoted-to-the-experimental-channel/2465/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment