New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate connection entries from advanced options list #3511

Merged
merged 2 commits into from Nov 24, 2018

Conversation

Projects
None yet
3 participants
@warwickmm
Copy link
Contributor

warwickmm commented Nov 23, 2018

This removes duplicate connection entries from the advanced options list. Since the IConnectionModule interface implements the IGenericModule interface, we do not need to add the connection modules separately.

This addresses issue #2184.

warwickmm added some commits Nov 23, 2018

Remove duplicate entries from advanced options list.
Since the IConnectionModule interface implements the IGenericModule
interface, we do not need to add the connection modules separately.

This addresses issue #2184.
@Pectojin

This comment has been minimized.

Copy link
Member

Pectojin commented Nov 24, 2018

Looks good to me 👍

@Pectojin Pectojin merged commit ec68a7c into duplicati:master Nov 24, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@warwickmm warwickmm referenced this pull request Nov 24, 2018

Closed

Some Advanced Options are listed twice #2184

1 of 1 task complete

@warwickmm warwickmm deleted the warwickmm:remove_duplicate_http_options branch Nov 24, 2018

@duplicatibot

This comment has been minimized.

Copy link

duplicatibot commented Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment