Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed account id to reduce confusion #3647

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
6 participants
@Pectojin
Copy link
Member

commented Feb 5, 2019

Cosmetic change for #3366 (comment)

Nothing needs to change in the backend code, since it's always worked with Application ID, but since Account ID does not work anymore this will reduce confusion.

@warwickmm

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

👍

I'm not too familiar with how the translations work, but does this affect translations by changing an existing msgid?

@Pectojin

This comment has been minimized.

Copy link
Member Author

commented Feb 6, 2019

Yes, all languages will have to retranslate the phrase. Which is ideal since they've all been saying the wrong thing presumably.

@kenkendk kenkendk merged commit 02968c8 into duplicati:master Feb 6, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ts678

This comment has been minimized.

Copy link

commented Feb 6, 2019

b2_authorize_account says:

You can use either the master application key or a normal application key.

You'll find the master key on the B2 Cloud Storage Buckets page on the web site. When using the master key, the "key id" is your account ID, and the "application key" is the one you got from the web site.

and both ways still work here. I'm worried by rclone which sounds like yours, so I'm not sure which is correct...

@ikjadoon

This comment has been minimized.

Copy link

commented Feb 7, 2019

Thank you for the follow-up, @ts678, and thank you for creating this commit, @Pectojin.

My previous comment simplified it a bit too much and ts678 is correct that they both can work, but the wording in Duplicati is just a tad off. After further study, here's what I've figured out:

In B2, there are two types of access. To give access to all buckets, the API will only accept:

  1. Account ID (automatically generated for each B2 account) plus...
  2. Master Application Key (must be generated in the B2 Buckets menu)

To give access to one bucket, the API will only accept:

  1. Application Key ID (generated upon creating a new application key) plus...
  2. Application Key (generated upon creating a new application key)

Thus, four unique inputs and only a "matching set" will authorize properly in the B2 API. Account ID & Master Application Key must always go together; Key ID and Application Key must always go together. I could see Duplicati users needing either or other, so perhaps removing "account ID" might end up adding more confusion.

I apologize for my previous inaccurate comment.

For what it's worth, B2's documentation explains this distinction....not easily and I needed to read it thrice to understand the two authentication sets. For further validation, Transmit's explanation matches the above, as does this comment by a Backblaze employee:

image

TL;DR both can be used, but Duplicati should add "Master Application Key" to the text

Perhaps like so:

Account ID (all buckets) or Key ID (one bucket)
Master Application Key (all buckets) or Application Key (one bucket)

If that's too much text, then perhaps just adding "Master Application Key" to the second box's prompt and users can try to mentally match them.

@Pectojin

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

That makes sense, although a bit confusing.

I think "application id" does a decent job of conveying "[bucket or master] application id", since both are called application id's.

@ikjadoon

This comment has been minimized.

Copy link

commented Feb 7, 2019

Absolutely confusing, I agree. B2's vague GUI doesn't help.

//

Valid point, though B2 doesn't ever actually use "Application ID" and you can't find that on the interface. It's either "ApplicationKeyID" (the API title) or "KeyID" (the interface title; see 3 below).

image

Maybe Key/Account ID and Application/Master Key ?

@duplicatibot

This comment has been minimized.

Copy link

commented Jun 8, 2019

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/setting-up-duplicati-only-as-a-cli-on-a-web-db-server/7239/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.