Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose backends after upload operations #3809

Merged
merged 4 commits into from Jul 9, 2019

Conversation

Projects
None yet
3 participants
@warwickmm
Copy link
Contributor

commented Jul 6, 2019

This ensures that instances of IBackend are disposed of after their use in put operations. This was previously achieved via a BackendHandler instance. However, after implementing parallel uploads in pull request #3684, we neglected to ensure the disposal of the multiple backends. This would cause some connections (e.g., SFTP) to remain open, and users could encounter a maximum connection limit.

This also removes the unused instance of BackendHandler in the BackupHandler.

This fixes issue #3808.

warwickmm added some commits Jul 6, 2019

Make Worker implement IDisposable.
This will allow the underlying Task and Backend to be disposed.
@duplicatibot

This comment has been minimized.

Copy link

commented Jul 6, 2019

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/backups-to-sftp-not-closing-connection/7481/5

@Pectojin Pectojin merged commit 042a5d9 into duplicati:master Jul 9, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@warwickmm warwickmm deleted the warwickmm:dispose_backends branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.