Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong reward in GQL #1390

Closed
herr-seppia opened this issue May 6, 2022 · 0 comments · Fixed by #1391
Closed

Wrong reward in GQL #1390

herr-seppia opened this issue May 6, 2022 · 0 comments · Fixed by #1391
Assignees
Labels
area:API Issues related to API, usually used together with other labels such type:refactor, etc. mark:testnet type:bug Something isn't working

Comments

@herr-seppia
Copy link
Member

Describe the bug
Reward shown in GQL endpoint is missing the distribution reward, so it's just the sum of fee paid

To Reproduce
GQL query the current devnet

  blocks(hash: "a85bcbfbc157ead5922961a6d751c01ef455ee45d90aebfd44dc047e78af5d31") {
    header {
      reward
      feespaid
      height
      timestamp
      step
    }
  }

Expected behaviour
Reward should be the sum of every tx's fee + emission amount

Logs/Screenshot

    "blocks": [
      {
        "header": {
          "feespaid": 723145951,
          "height": 8667,
          "reward": 723145951,
          "step": 3,
          "timestamp": "2022-05-06 10:56:45 +0000 UTC"
        }
      }
    ],

Platform
N/A

Additional context
The reward resolver has not been updated after the removal of the distribute transaction

@herr-seppia herr-seppia self-assigned this May 6, 2022
herr-seppia added a commit that referenced this issue May 6, 2022
herr-seppia added a commit that referenced this issue May 6, 2022
@herr-seppia herr-seppia added type:bug Something isn't working area:API Issues related to API, usually used together with other labels such type:refactor, etc. labels May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Issues related to API, usually used together with other labels such type:refactor, etc. mark:testnet type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant