macro: Add end-to-end test harness#30
Merged
Merged
Conversation
Cover the gap between unit tests of validation helpers and the single end-to-end shape in tests/test-contract: trybuild compile-fail fixtures pin every rejection rule in validate.rs, and a compile-pass sub-crate pins valid contract shapes the reference contract does not exercise. - Reorganize the 4 existing compile-fail fixtures under topic dirs (directives/, feature_gates/) and widen the trybuild glob to tests/compile-fail/**/*.rs. - Add 20 compile-fail fixtures (methods/, traits/, events/), one per validate.rs rejection rule, each carrying a // Pins: header that traces back to the rule identifier. - Add tests/compile-pass/ sub-crate with a topic-mirroring layout and a tests/compile_pass.rs driver that runs cargo check on it; the sub-crate is used (instead of trybuild's compile_pass glob) because the macro emits a compile_error! without a feature set and trybuild has no per-fixture feature configuration. - Add tests/README.md covering the topic taxonomy, the // Pins: header convention, the rationale for the sub-crate layout, and the absence of _dd.rs (data-driver-js) variants. Nothing in contract-macro/src/ or tests/test-contract/ is edited.
HDauven
approved these changes
May 16, 2026
Member
HDauven
left a comment
HDauven
left a comment
There was a problem hiding this comment.
LGTM!
Great that we now have such an extensive test harness 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #29