Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no space between bytes and units #32

Closed
nhooyr opened this issue Mar 28, 2016 · 3 comments

Comments

@nhooyr
Copy link

commented Mar 28, 2016

We should revert #21 for bytes or have some sort of configuration. I've never seen a space before like this.

http://www.staples.ca/en/USB-Flash-Drives/Kingston/cat_CL200543_2-CA_1_20001%3Ffids%3D4214939354

http://www.bestbuy.ca/en-CA/category/desktop-memory-ram/20359.aspx

It just looks so weird to me. I've reverted the commit in my fork but I'd be nice to see it in the main repo.

@nhooyr nhooyr changed the title revert #21 for bytes or some sort of configuration no space between bytes and units Mar 28, 2016

@dustin

This comment has been minimized.

Copy link
Owner

commented Mar 28, 2016

It looks weird to me as well, but I don't set the standards.

Do you have a reference (other than random web developers at stores) for
the correct format? Even if it's not hugely useful, it's surely best to do
the right thing WRT SI.

On Mon, Mar 28, 2016 at 2:13 PM Anmol Sethi notifications@github.com
wrote:

I don't think it should be the same for bytes, I've never seen a space
before like this.

http://www.staples.ca/en/USB-Flash-Drives/Kingston/cat_CL200543_2-CA_1_20001%3Ffids%3D4214939354

http://www.bestbuy.ca/en-CA/category/desktop-memory-ram/20359.aspx

It just looks really weird to me.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#32

@dmitshur

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2016

I've never seen a space before like this

Here's a screenshot from an OS X "About this Mac" view:

image

It's better and easier to follow a standard, SI in this case, than to try to invent one's own ad-hoc solutions. If you need custom behavior for a specific app, you should do something custom. This library tries to stay general and useful to most people, and following the SI standard is a good decision for it IMO.

@nhooyr

This comment has been minimized.

Copy link
Author

commented Mar 28, 2016

Alright, gonna close then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.