Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a key resets it's expiry #18

Closed
ryanslade opened this issue May 5, 2016 · 1 comment
Closed

Updating a key resets it's expiry #18

ryanslade opened this issue May 5, 2016 · 1 comment

Comments

@ryanslade
Copy link

https://github.com/dustin/gomemcached/blob/master/client/mc.go#L389

Why is this done? It appears to ignore the expiry value passed in and reset it to 0.

In our system, this leads to updated keys never expiring. The fix is easy, but wondering why this was done in the first place?

@dustin
Copy link
Owner

dustin commented May 5, 2016

It's a bit unclear. It seemed that every path was wrong, but that one probably looks more wrong than resetting it to the supplied value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants