Skip to content

Commit

Permalink
Move superfluous log message from info to debug.
Browse files Browse the repository at this point in the history
Motivation
----------
In every log when connecting, a message like this shows up:

INFO [Memcached IO over {MemcachedConnection to ...}] (?:?) - 
Connection state changed for sun.nio.ch.SelectionKeyImpl@...

This message is superfluous since it does not provide any addition 
information to the user, especially not at INFO level.

Modifications
-------------
The message has been moved to DEBUG level so that users are not 
wondering what it means and also to streamline the log a bit.

Result
------
Easier log output to read and analyze for the user.

Change-Id: I13ef691dd435f397dc9d5f08ff40a28202d3ddb7
Reviewed-on: http://review.couchbase.org/37647
Tested-by: Michael Nitschinger <michael.nitschinger@couchbase.com>
Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  • Loading branch information
daschl authored and Michael Nitschinger committed Jun 2, 2014
1 parent de62e2b commit 4aae4c5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/net/spy/memcached/MemcachedConnection.java
Expand Up @@ -637,7 +637,7 @@ private void handleIO(final SelectionKey sk) {
sk.isReadable(), sk.isWritable(), sk.isConnectable(),
sk.attachment());
if (sk.isConnectable() && belongsToCluster(node)) {
getLogger().info("Connection state changed for %s", sk);
getLogger().debug("Connection state changed for %s", sk);
final SocketChannel channel = node.getChannel();
if (channel.finishConnect()) {
finishConnect(sk, node);
Expand Down

0 comments on commit 4aae4c5

Please sign in to comment.