Permalink
Commits on Oct 23, 2011
  1. Update maven dependencies and metadata for more completion and accuracy.

    ingenthr committed with ingenthr Oct 23, 2011
    Change-Id: I3e5de47f609b52dd2dfe8d3cfc3803cee4c46f92
    Reviewed-on: http://review.couchbase.org/10302
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  2. Update maven pom generation with more detail.

    ingenthr committed with ingenthr Oct 23, 2011
    Change-Id: I80dca6250f7b3f72c6175dce7769f91908f74770
    Reviewed-on: http://review.couchbase.org/10301
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  3. Update to Netty 3.2.0.Final.

    ingenthr committed with ingenthr Oct 23, 2011
    We have already updated 2.7.3 to Netty 3.2.0 and added compatibility
    with either 3.1.5.GA or 3.2.0.Final.
    
    In 2.8, we will support only 3.2.0.Final, though 2.7.x will continue
    to support 3.1.5.GA.
    
    Change-Id: I86ca4471c3b845a2f4edd0004a4ec9ad9d766e7b
    Reviewed-on: http://review.couchbase.org/10300
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  4. Skip all ConfigurationProvider tests when testing against memcached.

    ingenthr committed with ingenthr Oct 23, 2011
    Change-Id: I85bef0e42146e90c58082a4c175b41d47112f5b5
    Reviewed-on: http://review.couchbase.org/10299
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  5. Rename and fix VBucketMemcachedClientTest to VBucketMembaseClientTest.

    ingenthr committed with ingenthr Oct 23, 2011
    This test was causing other test failures because it didn't clean up
    after itself.  When trying to determine why the test was even used
    here, I realized it had not been renamed in the refactoring between
    2.7 and 2.8.
    
    Change-Id: Icf3fb6a3750572685d9806aa6f90af23f25eadc6
    Reviewed-on: http://review.couchbase.org/10297
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  6. SPY-58: Don't compress json objects

    Mike Wiederhold committed with ingenthr Oct 21, 2011
    We don't actually parse the whole object. Instead we look
    at the first character and if it looks like json then we
    don't compress it.
    
    Change-Id: If60423b56ebf22c4529bffe95496ffe8b833a65f
    Reviewed-on: http://review.couchbase.org/10260
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
Commits on Oct 22, 2011
  1. Fixed a typo when computing vbucketlist size for tap messages.

    Mike Wiederhold committed with ingenthr Oct 22, 2011
    Change-Id: I2e3807f976363e8b8bd985e9b6faa283875ed7f1
    Reviewed-on: http://review.couchbase.org/10294
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  2. Fixed testOverflowing ReadQueue in QueueOverflowTest

    Mike Wiederhold committed with mikewied Sep 15, 2011
    The issue with this test failing inconsistently has to do with
    how many operations are in the input queue when the first
    queue overflow occurs. The queue size is 5 and if there are more
    than 5 operations in the input queue then this will cause a second
    queue overflow when we try to do our final operation. This fix
    corrects the error by making sure that we drain all of the
    operations from the write queue and therefore make sure that there
    is actually space for the last operation.
    
    Change-Id: I1e793514e8b1df1dbcdb133fba7cec837994b6d9
    Reviewed-on: http://review.couchbase.org/9613
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Oct 21, 2011
  1. SPY-4: Get CouchDB config info from config

    Mike Wiederhold committed with mikewied Sep 26, 2011
    Change-Id: I00472392dd0c9a892f3f5ed2dd62249844ab92e8
    Reviewed-on: http://review.couchbase.org/9760
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Oct 19, 2011
  1. Fixed checkstyle issues from merge with refresh

    Mike Wiederhold committed with mikewied Oct 19, 2011
    Change-Id: If8d61bd1e016afbac8f79c8b5481f1bb60c79b06
    Reviewed-on: http://review.couchbase.org/10202
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  2. SPY-48: Incr/Decr param "by" should be able to take a long

    Mike Wiederhold committed with mikewied Sep 5, 2011
    Change-Id: I4291caf70e28db19adb1754b5db6cdd364ef836a
    Reviewed-on: http://review.couchbase.org/9389
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Oct 18, 2011
  1. Merge branch 'refresh'

    ingenthr committed Oct 18, 2011
    Note there are three public variables that don't pass our
    checkstyle.  I'm proposing they be merged as is and then
    fixed in subsequent changes.
    
    * refresh:
      Continue to other URIs if one in the list is down. SPY-60.
      Revert "SPY-37 & SPY-38: Fixed redistribution performance issue"
      No need for old debugging string in test.
      Add compatibility with netty 3.2.0+.
      Refactored tap message classes.
      SPY-37 & SPY-38: Fixed redistribution performance issue
      Made vbmap in MultiKey operation synchronized
      Don't reconnect when a tap connection finishes.
      Flush the PrintWriter in TapMessagePrinter
      Removed extra variables in tapCustom header
      Removed a print line statement from TestConfig
    
    Change-Id: Icfc3f78fe00d1254f5ed30e1776301171b5e54a7
Commits on Oct 14, 2011
  1. Continue to other URIs if one in the list is down. SPY-60.

    ingenthr committed with ingenthr Sep 30, 2011
    Change-Id: Ic68ba9db5b5f645d3affc6964f7b2b90d309e519
    Reviewed-on: http://review.couchbase.org/10026
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
Commits on Oct 12, 2011
  1. Format the readme correctly.

    dustin committed Oct 12, 2011
    Change-Id: I4e7b13fcb0a925277761c32373b3696eed9daa0a
    Reviewed-on: http://review.couchbase.org/10098
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Dustin Sallings <dustin@spy.net>
Commits on Oct 11, 2011
  1. Revert "SPY-37 & SPY-38: Fixed redistribution performance issue"

    ingenthr committed with mikewied Oct 11, 2011
    This reverts commit 48e7e62.
    
    Change-Id: I9f6bc488406fc9c5ce537454b773d9baf21e379d
    Reviewed-on: http://review.couchbase.org/10059
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Commits on Oct 9, 2011
  1. No need for old debugging string in test.

    ingenthr committed with mikewied Oct 9, 2011
    Change-Id: I31ad1af2e6d0a33fa8534fa09e3f30175b931408
    Reviewed-on: http://review.couchbase.org/10027
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Commits on Oct 8, 2011
  1. Add compatibility with netty 3.2.0+.

    magro committed with ingenthr Sep 29, 2011
    Netty 3.2.0+ (NETTY-281) changed HttpMessage.setHeader(String, String) to
    setHeader(String, Object), which causes NoSuchMethodErrors when spymemcached is
    used with such a newer netty version. To prevent spymemcached users from other
    library incompatibilities the netty dependency is not upgraded, but the
    appropriate setHeader method is selected and invoked at runtime. This was
    discussed on the mailing list:
    http://groups.google.com/group/spymemcached/browse_thread/thread/4b9f0638bbcc96fb
    
    Change-Id: I1d2e7c4a3e6db6648d175364950eab6076a45e5f
    Reviewed-on: http://review.couchbase.org/9852
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
Commits on Oct 7, 2011
  1. Refactored tap message classes.

    Mike Wiederhold committed with ingenthr Sep 22, 2011
    These needed to be more readable and were horribly coded (by me). I
    started seeing issues with conversion from bytes on the wire to
    variables in spy so I changed how this was done.
    
    Change-Id: I583c43216643b111b6256f39ca475582b37267c6
    Reviewed-on: http://review.couchbase.org/9712
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  2. Recognize a query is using a json object and don't quote it

    Mike Wiederhold committed with ingenthr Oct 6, 2011
    This fixes an issue where sending json object as the value to the
    key argument in a query was getting quotes put around it. We now
    check to see if something is a json object before we decide to
    put quotes around it.
    
    Change-Id: Icc9b70a068af8383a4da3045628e999a8df811d8
    Reviewed-on: http://review.couchbase.org/9986
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
Commits on Oct 3, 2011
  1. SPY-37 & SPY-38: Fixed redistribution performance issue

    Mike Wiederhold committed with mikewied Sep 12, 2011
    This issue was caused by a O(n^3) algorithm used when redistributing
    operations among nodes. It turns out that one of the loops was not
    necessary because the clone operation is guaranteed to return a
    list of single key operations. Multi-key operations are never
    returned as part of this list.
    
    The fix involves removing the one of these loops. which frequently
    queued duplicate operations for transmission. Since the
    operations are all single key, the list returned by the call
    getKeys() is guaranteed to have only one operation.
    
    Change-Id: Id8cf17132bff06dba78935cbb8b81d83f58b4bc2
    Reviewed-on: http://review.couchbase.org/9514
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Sep 29, 2011
  1. Updated README.markdown to reflect the new build file

    Mike Wiederhold committed with mikewied Sep 26, 2011
    Change-Id: I33890737d862ec38e29e1c5e09f3d338652e97f2
    Reviewed-on: http://review.couchbase.org/9765
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
  2. Made vbmap in MultiKey operation synchronized

    Mike Wiederhold committed with mikewied Sep 26, 2011
    There was a concurrency issue here that has to do with accessing a
    two threads accessing the same set. One thread is iterating over
    the set and the other is modifying the set. This modification
    causes iteration to undefined and therefore java throws an error.
    
    Change-Id: I17ea7a0146443ed1ef4578fb04cab431a3e723d7
    Reviewed-on: http://review.couchbase.org/9769
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Sep 28, 2011
  1. The jar target now builds a jar of all of the test classes

    Mike Wiederhold committed with mikewied Sep 26, 2011
    Change-Id: I1c2e862699f1784bde1294ad62996ebfacfbe1bf
    Reviewed-on: http://review.couchbase.org/9764
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  2. Install javadocs java into local maven when doing ant mvn-install

    Mike Wiederhold committed with mikewied Sep 26, 2011
    Change-Id: Ie63b1479bb6dfa4959f78429159c4eb45573d2a5
    Reviewed-on: http://review.couchbase.org/9763
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  3. Made package the default target and made it build all jars

    Mike Wiederhold committed with mikewied Sep 26, 2011
    Change-Id: Iaa0490030d869897b837e6f5bd38ba5332e34827
    Reviewed-on: http://review.couchbase.org/9762
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  4. Added a docsjar target

    Mike Wiederhold committed with mikewied Sep 26, 2011
    This target creates a javadoc jar file from the generated docs
    
    Change-Id: I65c4084df0a4b0ea0e2cedbd934eb0dab2ea378d
    Reviewed-on: http://review.couchbase.org/9761
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Sep 25, 2011
  1. SPY-26: Add Getl Tests

    Mike Wiederhold committed with mikewied Sep 7, 2011
    Change-Id: I3d512837f31d5e4d46096235a49f65245895de77
    Reviewed-on: http://review.couchbase.org/9452
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  2. Don't reconnect when a tap connection finishes.

    Mike Wiederhold committed with mikewied Sep 22, 2011
    Change-Id: I7c70697bdd8f67f451c514193ae2d6fa2856dfc7
    Reviewed-on: http://review.couchbase.org/9711
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Sep 24, 2011
  1. Merge "Merge branch 'refresh'"

    Mike Wiederhold committed with Gerrit Code Review Sep 24, 2011
  2. Flush the PrintWriter in TapMessagePrinter

    Mike Wiederhold committed with mikewied Sep 22, 2011
    This doesn't print anything until you flush.
    
    Change-Id: Icc98b26ecb1da4c9f3dbf96f9e827801f3b807b1
    Reviewed-on: http://review.couchbase.org/9710
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  3. Removed extra variables in tapCustom header

    Mike Wiederhold committed with mikewied Sep 20, 2011
    We abandoned my rudamentry key/value filter change a while ago but
    the tapCustom signature was never updated.
    
    Change-Id: I76cea19b3b74cceee3316f39d0565b9959547867
    Reviewed-on: http://review.couchbase.org/9674
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Sep 22, 2011
  1. Removed a print line statement from TestConfig

    Mike Wiederhold committed with mikewied Sep 22, 2011
    Change-Id: I9f060ab36a407eb91dd3a8b784cd7c854e2d706d
    Reviewed-on: http://review.couchbase.org/9713
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Commits on Sep 20, 2011
  1. Fixed ASCII getl issue.

    Mike Wiederhold committed with dustin Sep 20, 2011
    When processing errors Spymemcached had no notion of what
    LOCK_ERROR was. This fix allows Spy to handle the LOCK_ERROR.
    
    Change-Id: I07fcc169a34dd5d14156c82ebdc1a99c785992de
    Reviewed-on: http://review.couchbase.org/9678
    Reviewed-by: Dustin Sallings <dustin@spy.net>
    Tested-by: Dustin Sallings <dustin@spy.net>
  2. Merge branch 'refresh'

    Mike Wiederhold committed Sep 20, 2011
    Changes Merged:
    	Made cmd variable a byte for binary operations
    	SPY-51: Bug in OperationImpl's decodeLong(2)
    
    Change-Id: I9ee8170c20f668d804d083a6d89832c73ad119ee
  3. Made cmd variable a byte for binary operations

    Mike Wiederhold committed with mikewied Sep 8, 2011
    This variable should have never been an int since it is defined in
    the protocol as a byte. The reason for the change is that when we
    have opcode that is greater have 127 the value of a byte and an int
    are different (Ex. int = 128 byte = -127). This was causing an
    assertion to fail, in this case for the getl command (0x94).
    
    Change-Id: Ia6b32a4af94ed2e8dc973237132f3fd291655634
    Reviewed-on: http://review.couchbase.org/9476
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>