Permalink
Commits on Jan 22, 2012
  1. Add Iterator versions of getAsyncBulk and getBulk

    Add the following methods to Memcached/MemcachedIF:
    - <T> BulkFuture<Map<String, T>> asyncGetBulk(Iterator<String> keys,
          Iterator<Transcoder<T>> tcs);
    - <T> BulkFuture<Map<String, T>> asyncGetBulk(Iterator<String> keys,
          Transcoder<T> tc);
    - BulkFuture<Map<String, Object>> asyncGetBulk(Iterator<String> keys);
    - <T> Map<String, T> getBulk(Iterator<String> keys, Transcoder<T> tc);
    - Map<String, Object> getBulk(Iterator<String> keys);
    
    Some times it is more convenient/memory efficent to pass in an
    Iterator of keys than it is to have a Collection of them.
    
    Example:
    
    public PrefixAdderIterator implements Iterator<String> {
    
      private final String prefix;
      private final Iterator<String> iterator;
      public PrefixAdderIterator(String prefix,
             Iterator<String> iterator) {
        this.prefix = prefix;
        this.iterator = iterator;
      }
      ...
      public String next() {
        return prefix+iterator.next();
      }
     ...
    }
    
    rather than
    
     List<String> prefixedKeys = new ArrayList<String>();
     for (String key: keys) {
      prefixedKeys.add(prefix+key);
     }
    
    Change-Id: I15821983ea2ebd07fd98feeb968ce9fa578ded0b
    Reviewed-on: http://review.couchbase.org/12283
    Reviewed-by: Ted Crossman <tedoc2000@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Ted Crossman committed with ingenthr Jan 11, 2012
  2. Changes to do a staging of Maven locally

    Incorporated chanes Ife95d2f4, I34b46bc0, Ib71d9ab4 from
    couchbase-java-client.
    
    Change-Id: I2523f96e6e0fe1791876001bbc345a23674ba6dc
    Reviewed-on: http://review.couchbase.org/12581
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    ragsns committed with ingenthr Jan 22, 2012
  3. Added Javadocs JAR publication

    Change-Id: I90f78654835939305bb0342f8442ea8a54cabd14
    Reviewed-on: http://review.couchbase.org/12575
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    ragsns committed with ingenthr Jan 22, 2012
  4. Changes to stage Maven repository locally

    Added a target mvn-stage to stage repository to {user.home}/mvn-stage
    Based on http://draconianoverlord.com/2010/07/18/publishing-to-maven-repos-with-ivy.html
    
    Change-Id: I90eaf4107ef8942855cb9c125d2428fe6076e538
    Reviewed-on: http://review.couchbase.org/12573
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    ragsns committed with ingenthr Jan 22, 2012
Commits on Jan 12, 2012
  1. Split tap flags class into request and response

    Tap requests and responses flags have different meanings. They
    should be represented by two different classes.
    
    Change-Id: Ib5f8d76aa6ce05cf8f5c15980f29b8e93100d6a8
    Reviewed-on: http://review.couchbase.org/12298
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Jan 12, 2012
Commits on Jan 11, 2012
  1. Added a tap client back to Spymemcached

    The tap client was removed from Spymemcached when we split the
    project in two. Since Spymemcached supports some of tap I have
    moved back only the code that makes sense. After this commit
    Spymemcached will support only the tap dump command. Note I
    have also left the tap custom function in case future versions
    of memcached support more tap options and Spymemcached is unable
    to keep up. This tapCustom function will also allow people who
    write their own engines for memcached to take full advantage of
    the tap protocol.
    
    Change-Id: Ief2909d0177c944dc39023b205f5fad03f3acb97
    Reviewed-on: http://review.couchbase.org/12158
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Mike Wiederhold committed with ragss Jan 9, 2012
Commits on Jan 8, 2012
  1. Fixed javadoc warnings

    Change-Id: I401beb3473631024d9362451cb5f3b0a4f72277d
    Reviewed-on: http://review.couchbase.org/12143
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Mike Wiederhold committed with ingenthr Jan 8, 2012
  2. Made getNodeLocator() public

    We are refactoring the package names in couchbase client and
    need access to this function from outside of the package space.
    
    Change-Id: Idbab18ffa7d30400fb7c066f3ccdace2e93201e2
    Reviewed-on: http://review.couchbase.org/12049
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Mike Wiederhold committed with ingenthr Jan 8, 2012
  3. Moved addOp() to MemcachedConnection

    Change-Id: Ia2b64253cb24331e73806ebd92a2501f029439c4
    Reviewed-on: http://review.couchbase.org/12142
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Jan 8, 2012
  4. Removed server.type parameter

    Spymemcached is only meant to work against memcached now so we
    don't need the ability to include/exclude tests.
    
    Change-Id: I816a86405c4d0d4d696f72bcf115e98b1e8632aa
    Reviewed-on: http://review.couchbase.org/12141
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Jan 6, 2012
  5. Moved validateKey function to StringUtils class

    Change-Id: I194dc2f7feb59d49579ec5123e21d17bbf3b6ef9
    Reviewed-on: http://review.couchbase.org/12139
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Jan 8, 2012
  6. Provide test type default value and print it at test time

    Fixed checkstyle errors as well
    
    Change-Id: Ie28277585c7da21e8ab4dbf5d738e69e24597a02
    Reviewed-on: http://review.couchbase.org/12137
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Jan 8, 2012
  7. Added the capability to test based on different ports

    Memcached can start on different ports and the tests can be configured to
    run correctly than using the default 11211
    Fixed checkstyle errors as well.
    
    Change-Id: Ie2a589dc5040d465eb74bb7918f866165109d011
    Reviewed-on: http://review.couchbase.org/12127
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Jan 8, 2012
  8. Fixed checkstyle errors

    Change-Id: I497286aa37a37b251681e42a8fcdd45ce8dc5577
    Reviewed-on: http://review.couchbase.org/12138
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Jan 8, 2012
Commits on Jan 6, 2012
  1. Added options to selectively run some tests for CI

    Change-Id: Ia6606f73d9fd8006ee4b714bbfc25e320370d414
    Reviewed-on: http://review.couchbase.org/12088
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    ragsns committed with mikewied Jan 5, 2012
  2. SPY-69: Fixed CASMutator expiration issue

    The cas call in this class wasn't using the function that allows
    the expiration to be specified. As a result, if the CASMutator was
    used and an item was already in memcached then the expiration would
    be set to 0.
    
    Change-Id: I49e28b2c89555ebbc24dc8db109fc5c0a7b40cf4
    Reviewed-on: http://review.couchbase.org/12052
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Jan 4, 2012
Commits on Jan 3, 2012
  1. Fixed project description

    Change-Id: I9b10e2b4fbed283aa124f7db8a5ee91a163c2f40
    Reviewed-on: http://review.couchbase.org/11109
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Mike Wiederhold committed with ingenthr Nov 18, 2011
  2. Don't put test after ther version # on test jars

    Change-Id: I3cb98b7fe7be52e59fb96fe9fdd6ef04ce25ed04
    Reviewed-on: http://review.couchbase.org/11108
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Mike Wiederhold committed with ragss Nov 17, 2011
  3. Don't hardcode "spymemcached" the buildfile

    Change-Id: I35b144c70d382da5a862119cf762ca6383323f95
    Reviewed-on: http://review.couchbase.org/11107
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Mike Wiederhold committed with ragss Nov 17, 2011
Commits on Jan 2, 2012
  1. Only generate a version once in the build file

    Change-Id: I90619ff869d49b31c09a227bb96e9f1d6dbe0d7b
    Reviewed-on: http://review.couchbase.org/11106
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Nov 17, 2011
  2. Remove tests that checked for Membase/Couchbase

    Change-Id: I0dd8e0acbe9eecc06542ca4fee45de99c1844227
    Reviewed-on: http://review.couchbase.org/11105
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Nov 17, 2011
  3. POM files now generate the correct scopes

    Change-Id: I924eb5b3df30241b21b4dd101f5962268ea05911
    Reviewed-on: http://review.couchbase.org/11104
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Nov 17, 2011
  4. Remove unused dependencies

    Change-Id: Ie1bdaa247966a42d830fdce51b770fb36f4db324
    Reviewed-on: http://review.couchbase.org/11103
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Nov 17, 2011
  5. mvn-install publishes spymemcached test cases

    Since we will be creating projects based on Spymemcached
    we will want to be able to import the Spymemcached test
    cases into those projects so we can extend and use some of
    the existing test cases. This change allows us to publish
    a jar of Spymemcached tests into maven.
    
    Change-Id: Ida7f38c0bb94a420e24ec935a3b68e1d70cae6aa
    Reviewed-on: http://review.couchbase.org/11102
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Mike Wiederhold committed with ragss Nov 17, 2011
  6. Added variable names for versions to spymemcached.xml

    Change-Id: I65ea6f1aaf6c501e2f7746ec9027f20f517751ec
    Reviewed-on: http://review.couchbase.org/11101
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Nov 17, 2011
  7. Rewrote javadocs file attachment for mvn-install

    This shouldn't have it's own artifact:install function
    since it can be included in the one that already exists.
    
    Change-Id: I1512cdc6b76409796085ffdf8182a6d73fd4319b
    Reviewed-on: http://review.couchbase.org/11100
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Nov 17, 2011
  8. Removed all Membase and Couchbase support

    We are splitting up this project into two seperate projects. One
    project will support memcached and the other will support Membase
    and Couchbase.
    
    Change-Id: I383dfcde9b5c1fbd0225e5a5e8ee001e8e3ada60
    Reviewed-on: http://review.couchbase.org/11099
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Mike Wiederhold committed with ingenthr Nov 17, 2011
Commits on Oct 24, 2011
  1. Use variables for jar version names

    I just realized I +2'ed a commit that had these hard coded. The
    only place a version number should be hard coded is in the
    ivy/library.properties file.
    
    Change-Id: I033dcc36ffdb0795463794c2838dad651aeb4e3b
    Reviewed-on: http://review.couchbase.org/10304
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Mike Wiederhold committed with mikewied Oct 24, 2011
Commits on Oct 23, 2011
  1. Update maven dependencies and metadata for more completion and accuracy.

    Change-Id: I3e5de47f609b52dd2dfe8d3cfc3803cee4c46f92
    Reviewed-on: http://review.couchbase.org/10302
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    ingenthr committed with ingenthr Oct 23, 2011
  2. Update maven pom generation with more detail.

    Change-Id: I80dca6250f7b3f72c6175dce7769f91908f74770
    Reviewed-on: http://review.couchbase.org/10301
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    ingenthr committed with ingenthr Oct 23, 2011
  3. Update to Netty 3.2.0.Final.

    We have already updated 2.7.3 to Netty 3.2.0 and added compatibility
    with either 3.1.5.GA or 3.2.0.Final.
    
    In 2.8, we will support only 3.2.0.Final, though 2.7.x will continue
    to support 3.1.5.GA.
    
    Change-Id: I86ca4471c3b845a2f4edd0004a4ec9ad9d766e7b
    Reviewed-on: http://review.couchbase.org/10300
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    ingenthr committed with ingenthr Oct 23, 2011
  4. Skip all ConfigurationProvider tests when testing against memcached.

    Change-Id: I85bef0e42146e90c58082a4c175b41d47112f5b5
    Reviewed-on: http://review.couchbase.org/10299
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    ingenthr committed with ingenthr Oct 23, 2011
  5. Rename and fix VBucketMemcachedClientTest to VBucketMembaseClientTest.

    This test was causing other test failures because it didn't clean up
    after itself.  When trying to determine why the test was even used
    here, I realized it had not been renamed in the refactoring between
    2.7 and 2.8.
    
    Change-Id: Icf3fb6a3750572685d9806aa6f90af23f25eadc6
    Reviewed-on: http://review.couchbase.org/10297
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    ingenthr committed with ingenthr Oct 23, 2011
  6. SPY-58: Don't compress json objects

    We don't actually parse the whole object. Instead we look
    at the first character and if it looks like json then we
    don't compress it.
    
    Change-Id: If60423b56ebf22c4529bffe95496ffe8b833a65f
    Reviewed-on: http://review.couchbase.org/10260
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Mike Wiederhold committed with ingenthr Oct 21, 2011
Commits on Oct 22, 2011
  1. Fixed a typo when computing vbucketlist size for tap messages.

    Change-Id: I2e3807f976363e8b8bd985e9b6faa283875ed7f1
    Reviewed-on: http://review.couchbase.org/10294
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Mike Wiederhold committed with ingenthr Oct 22, 2011