Permalink
Commits on Mar 22, 2012
  1. Added toString() for ResponseMessage.

    ingenthr committed Feb 19, 2012
    Change-Id: Ie627cd14631a01a0258d67337251c552e90aa3bc
    Reviewed-on: http://review.couchbase.org/13361
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
Commits on Mar 21, 2012
  1. Make log4j, spring-beans optional in our maven artifacts.

    ingenthr committed with mikewied Mar 21, 2012
    Change-Id: I579a5832fc4ff0ed9d4303c80b309a25dc8cfbaf
    Reviewed-on: http://review.couchbase.org/14159
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
  2. Bump log4j to 1.2.16 to get rid of transitive JMS deps.

    ingenthr committed with mikewied Mar 21, 2012
    Change-Id: Ie98c136a0c1d450ba3aa5ccd12dfc40650653131
    Reviewed-on: http://review.couchbase.org/14158
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
  3. Complete the removal of stats cachedump.

    ingenthr committed Mar 21, 2012
    Unfortunately, late night coding means I put up a change and
    marked it verified, but it makes the project not compile.  Not
    worth rewriting history for these 5 commits or so, but need
    to fix it.
    
    See also http://review.couchbase.org/#change,14142
    
    Change-Id: I975a79774fe7d8ec0484fb69c0910525ed164b02
    Reviewed-on: http://review.couchbase.org/14143
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  4. Add test coverage for ResponseMessage and fix to get bytes.

    ingenthr committed Mar 16, 2012
    This adds test coverage to the ResponseMessage.  This test was used
    for finding and addressing a number of recent fixes and verifying
    correct support for requesting the flags to be sent correctly in
    network byte order.  These other fixes were added in recent commits.
    
    Change-Id: I68355b5ea10437c144a7b4a46adb7d005edfa0fc
    Reviewed-on: http://review.couchbase.org/13996
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  5. Decode TAP mutation flags as host byte order.

    ingenthr committed Feb 23, 2012
    In trying to decode the item flags from a tap mutation, it was found
    that the flags are stored in the server in network byte order, but
    when sent over tap it goes through htonl() conversion, making it a
    double conversion.
    
    Future versions of the server now allow for the client to specify
    it would like the flags sent correctly, via a TAP flag, and the
    server will set a flag to say they're being sent correctly.  With
    this change, we now request things to be correct and if we don't
    receive a flag saying it's correct, we swap the bytes (assuming we
    are talking to a 'broken' server).
    
    In developing this change, a test was also developed but to
    complete the test correctly, some other issues had to be fixed.
    Thus the test isn't in this commit, but rather in it's own commit
    after cleaning up the mess.
    
    Change-Id: I63b69273cac194163b784211474ec2ff77bd7959
    Reviewed-on: http://review.couchbase.org/13510
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  6. Fixed handling of TAP flags.

    ingenthr committed Mar 16, 2012
    The request and response messages for flags were not following the defined
    protocol for their data size.  Also, the logic in the setting of the flags
    was incorrect, meaning it wasn't actually possible to determine which
    flags were set.
    
    A test that verifies correct behavior will be added in a later commit
    that introduces test coverage for the ResponseMessage class.
    
    Change-Id: I20ae1b176cb3bc764e993ab98254b15f69cba9ea
    Reviewed-on: http://review.couchbase.org/13995
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  7. Wait longer on tap data received.

    ingenthr committed Feb 23, 2012
    Change-Id: I5279eec0f642688013c9a8d98ca4a7922cae9d42
    Reviewed-on: http://review.couchbase.org/13509
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  8. Remove test for "stats cachedump".

    ingenthr committed with mikewied Mar 21, 2012
    In the most recent memcached memcached branch, stats cachedump
    has been removed.  It now returns an error saying it's not supported.
    
    See also:
    http://code.google.com/p/memcached/issues/detail?id=207
    http://www.couchbase.com/issues/browse/MB-4058
    http://review.couchbase.org/#change,13854
    
    Change-Id: Ib3d344e7a0db28994017c515e1c56c4efdcfae19
    Reviewed-on: http://review.couchbase.org/14142
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
Commits on Feb 20, 2012
  1. Enhanced TapTest, ensuring success with random leftovers.

    ingenthr committed Feb 19, 2012
    Change-Id: Ia5ed0e3a6a2074a1dac229904826fdd838e06b37
    Reviewed-on: http://review.couchbase.org/13362
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  2. Made TapAck its own class

    Mike Wiederhold committed with ingenthr Feb 8, 2012
    This will help reduce having duplicate code.
    
    Change-Id: I96f7fb126ab3f7879e590131ded7229f9f75bc31
    Reviewed-on: http://review.couchbase.org/13084
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  3. Created TapStream abstraction

    Mike Wiederhold committed with mikewied Feb 8, 2012
    Previously when we created a tap stream we would only send it
    to a single node in the memcached cluster. This fix creates
    a tap stream abstraction that aggregates the tap streams
    sent to each server and treats them as a single tap stream.
    
    Change-Id: I68650e187eec5f79952dab1374bad0e07d5a6c30
    Reviewed-on: http://review.couchbase.org/13081
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Feb 6, 2012
  1. Added support for unl command

    ragsns committed with ragss Feb 1, 2012
    Based on patch submitted by Brent Ryan
    
    Change-Id: I9da7cc17eb5adedc9c2cac79ab562bab0fc7ba52
    Reviewed-on: http://review.couchbase.org/12908
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
Commits on Jan 22, 2012
  1. Add Iterator versions of getAsyncBulk and getBulk

    Ted Crossman committed with ingenthr Jan 11, 2012
    Add the following methods to Memcached/MemcachedIF:
    - <T> BulkFuture<Map<String, T>> asyncGetBulk(Iterator<String> keys,
          Iterator<Transcoder<T>> tcs);
    - <T> BulkFuture<Map<String, T>> asyncGetBulk(Iterator<String> keys,
          Transcoder<T> tc);
    - BulkFuture<Map<String, Object>> asyncGetBulk(Iterator<String> keys);
    - <T> Map<String, T> getBulk(Iterator<String> keys, Transcoder<T> tc);
    - Map<String, Object> getBulk(Iterator<String> keys);
    
    Some times it is more convenient/memory efficent to pass in an
    Iterator of keys than it is to have a Collection of them.
    
    Example:
    
    public PrefixAdderIterator implements Iterator<String> {
    
      private final String prefix;
      private final Iterator<String> iterator;
      public PrefixAdderIterator(String prefix,
             Iterator<String> iterator) {
        this.prefix = prefix;
        this.iterator = iterator;
      }
      ...
      public String next() {
        return prefix+iterator.next();
      }
     ...
    }
    
    rather than
    
     List<String> prefixedKeys = new ArrayList<String>();
     for (String key: keys) {
      prefixedKeys.add(prefix+key);
     }
    
    Change-Id: I15821983ea2ebd07fd98feeb968ce9fa578ded0b
    Reviewed-on: http://review.couchbase.org/12283
    Reviewed-by: Ted Crossman <tedoc2000@gmail.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  2. Changes to do a staging of Maven locally

    ragsns committed with ingenthr Jan 22, 2012
    Incorporated chanes Ife95d2f4, I34b46bc0, Ib71d9ab4 from
    couchbase-java-client.
    
    Change-Id: I2523f96e6e0fe1791876001bbc345a23674ba6dc
    Reviewed-on: http://review.couchbase.org/12581
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  3. Added Javadocs JAR publication

    ragsns committed with ingenthr Jan 22, 2012
    Change-Id: I90f78654835939305bb0342f8442ea8a54cabd14
    Reviewed-on: http://review.couchbase.org/12575
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  4. Changes to stage Maven repository locally

    ragsns committed with ingenthr Jan 22, 2012
    Added a target mvn-stage to stage repository to {user.home}/mvn-stage
    Based on http://draconianoverlord.com/2010/07/18/publishing-to-maven-repos-with-ivy.html
    
    Change-Id: I90eaf4107ef8942855cb9c125d2428fe6076e538
    Reviewed-on: http://review.couchbase.org/12573
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
Commits on Jan 12, 2012
  1. Split tap flags class into request and response

    Mike Wiederhold committed with mikewied Jan 12, 2012
    Tap requests and responses flags have different meanings. They
    should be represented by two different classes.
    
    Change-Id: Ib5f8d76aa6ce05cf8f5c15980f29b8e93100d6a8
    Reviewed-on: http://review.couchbase.org/12298
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Jan 11, 2012
  1. Added a tap client back to Spymemcached

    Mike Wiederhold committed with ragss Jan 9, 2012
    The tap client was removed from Spymemcached when we split the
    project in two. Since Spymemcached supports some of tap I have
    moved back only the code that makes sense. After this commit
    Spymemcached will support only the tap dump command. Note I
    have also left the tap custom function in case future versions
    of memcached support more tap options and Spymemcached is unable
    to keep up. This tapCustom function will also allow people who
    write their own engines for memcached to take full advantage of
    the tap protocol.
    
    Change-Id: Ief2909d0177c944dc39023b205f5fad03f3acb97
    Reviewed-on: http://review.couchbase.org/12158
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
Commits on Jan 8, 2012
  1. Fixed javadoc warnings

    Mike Wiederhold committed with ingenthr Jan 8, 2012
    Change-Id: I401beb3473631024d9362451cb5f3b0a4f72277d
    Reviewed-on: http://review.couchbase.org/12143
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  2. Made getNodeLocator() public

    Mike Wiederhold committed with ingenthr Jan 8, 2012
    We are refactoring the package names in couchbase client and
    need access to this function from outside of the package space.
    
    Change-Id: Idbab18ffa7d30400fb7c066f3ccdace2e93201e2
    Reviewed-on: http://review.couchbase.org/12049
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
  3. Moved addOp() to MemcachedConnection

    Mike Wiederhold committed with mikewied Jan 8, 2012
    Change-Id: Ia2b64253cb24331e73806ebd92a2501f029439c4
    Reviewed-on: http://review.couchbase.org/12142
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  4. Removed server.type parameter

    Mike Wiederhold committed with mikewied Jan 6, 2012
    Spymemcached is only meant to work against memcached now so we
    don't need the ability to include/exclude tests.
    
    Change-Id: I816a86405c4d0d4d696f72bcf115e98b1e8632aa
    Reviewed-on: http://review.couchbase.org/12141
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  5. Moved validateKey function to StringUtils class

    Mike Wiederhold committed with mikewied Jan 8, 2012
    Change-Id: I194dc2f7feb59d49579ec5123e21d17bbf3b6ef9
    Reviewed-on: http://review.couchbase.org/12139
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  6. Provide test type default value and print it at test time

    Mike Wiederhold committed with mikewied Jan 8, 2012
    Fixed checkstyle errors as well
    
    Change-Id: Ie28277585c7da21e8ab4dbf5d738e69e24597a02
    Reviewed-on: http://review.couchbase.org/12137
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  7. Added the capability to test based on different ports

    Mike Wiederhold committed with mikewied Jan 8, 2012
    Memcached can start on different ports and the tests can be configured to
    run correctly than using the default 11211
    Fixed checkstyle errors as well.
    
    Change-Id: Ie2a589dc5040d465eb74bb7918f866165109d011
    Reviewed-on: http://review.couchbase.org/12127
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  8. Fixed checkstyle errors

    Mike Wiederhold committed with mikewied Jan 8, 2012
    Change-Id: I497286aa37a37b251681e42a8fcdd45ce8dc5577
    Reviewed-on: http://review.couchbase.org/12138
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Jan 6, 2012
  1. Added options to selectively run some tests for CI

    ragsns committed with mikewied Jan 5, 2012
    Change-Id: Ia6606f73d9fd8006ee4b714bbfc25e320370d414
    Reviewed-on: http://review.couchbase.org/12088
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
  2. SPY-69: Fixed CASMutator expiration issue

    Mike Wiederhold committed with mikewied Jan 4, 2012
    The cas call in this class wasn't using the function that allows
    the expiration to be specified. As a result, if the CASMutator was
    used and an item was already in memcached then the expiration would
    be set to 0.
    
    Change-Id: I49e28b2c89555ebbc24dc8db109fc5c0a7b40cf4
    Reviewed-on: http://review.couchbase.org/12052
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
Commits on Jan 3, 2012
  1. Fixed project description

    Mike Wiederhold committed with ingenthr Nov 18, 2011
    Change-Id: I9b10e2b4fbed283aa124f7db8a5ee91a163c2f40
    Reviewed-on: http://review.couchbase.org/11109
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
  2. Don't put test after ther version # on test jars

    Mike Wiederhold committed with ragss Nov 17, 2011
    Change-Id: I3cb98b7fe7be52e59fb96fe9fdd6ef04ce25ed04
    Reviewed-on: http://review.couchbase.org/11108
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
  3. Don't hardcode "spymemcached" the buildfile

    Mike Wiederhold committed with ragss Nov 17, 2011
    Change-Id: I35b144c70d382da5a862119cf762ca6383323f95
    Reviewed-on: http://review.couchbase.org/11107
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
Commits on Jan 2, 2012
  1. Only generate a version once in the build file

    Mike Wiederhold committed with mikewied Nov 17, 2011
    Change-Id: I90619ff869d49b31c09a227bb96e9f1d6dbe0d7b
    Reviewed-on: http://review.couchbase.org/11106
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  2. Remove tests that checked for Membase/Couchbase

    Mike Wiederhold committed with mikewied Nov 17, 2011
    Change-Id: I0dd8e0acbe9eecc06542ca4fee45de99c1844227
    Reviewed-on: http://review.couchbase.org/11105
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
  3. POM files now generate the correct scopes

    Mike Wiederhold committed with mikewied Nov 17, 2011
    Change-Id: I924eb5b3df30241b21b4dd101f5962268ea05911
    Reviewed-on: http://review.couchbase.org/11104
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>