Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Sep 18, 2012

  1. Mike Wiederhold

    JCBC-110: Delete operation in MemcachedClient now returns it's cas

    Change-Id: Id70241db2e4111f335b76ed9e6c6179d266aee94
    Reviewed-on: http://review.couchbase.org/20852
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored September 13, 2012 ingenthr committed September 18, 2012
  2. Mike Wiederhold

    JCBC-110: Observe operations return their handling node in gotData

    Change-Id: I56f5f1844f0388a750ab5b5b4703e616b1e2aa10
    Reviewed-on: http://review.couchbase.org/20851
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored September 13, 2012 ingenthr committed September 18, 2012
  3. Mike Wiederhold

    JCBC-110: Add accessor funcitons to observe enum classes

    Change-Id: If6c8ecd0fd5be178001db7db229b94a9184a8a2f
    Reviewed-on: http://review.couchbase.org/20849
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored September 13, 2012 ingenthr committed September 18, 2012

Sep 17, 2012

  1. Mike Wiederhold

    JCBC-110: Fix getCas function in operation future

    We need to wait for the operation to complete if we call getCas
    and the operation is not finished otherwise calling this function
    will incorrectly throw an exception.
    
    Change-Id: Iefd90f04f8ebdeaf569b69be6dea7deac03a2c80
    Reviewed-on: http://review.couchbase.org/20848
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored September 13, 2012 ingenthr committed September 17, 2012

Sep 10, 2012

  1. Mike Wiederhold

    Broadcast operations only send to specified nodes

    This was causing observe replica broadcast to always have a positive
    countdown latch and timeout.
    
    Change-Id: I4b49cb094ede8875757eb4b09d7b5a5ee50e848a
    Reviewed-on: http://review.couchbase.org/20655
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored September 07, 2012 ingenthr committed September 10, 2012

Aug 31, 2012

  1. Rags

    Change cas for Observe Statuses, return OperationFuture on async.

    Change-Id: I11990b82473604406d0db9d1cdca000692023ed7
    Reviewed-on: http://review.couchbase.org/20327
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored August 30, 2012 ingenthr committed August 31, 2012

Aug 21, 2012

  1. Rags

    Fixed issues with the Observe Method(s)

    Change-Id: Id2a1483bc1c75268f579b3df88ae4e8d488b6f46
    Reviewed-on: http://review.couchbase.org/19919
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored August 20, 2012 ingenthr committed August 21, 2012

Aug 19, 2012

  1. Matt Ingenthron

    Add the node back to connected during reconnect. Issue 225.

    The connection was being added back a bit later than its
    reconnect, causing operations to continue to timeout.  It's
    not clear if this is platform specific or not, but this change
    is reported to work.
    
    See http://code.google.com/p/spymemcached/issues/detail?id=225
    
    Change-Id: I47960883b515a1d2b571e5b286179337dd960b2e
    Reviewed-on: http://review.couchbase.org/19847
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored August 19, 2012 ingenthr committed August 19, 2012
  2. Rags

    Fixed failing Unlock test

    Note this isn't a complete fix for handling unlock.  Several
    possible responses are ignored.  That is tracked under SPY-97
    for now.
    
    Change-Id: I20b0e9734c7fa170edcd38c76e59f353f4a4df41
    Reviewed-on: http://review.couchbase.org/19538
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored August 13, 2012 ingenthr committed August 19, 2012

Aug 17, 2012

  1. Rags

    Changes for Observe.

    Change-Id: I94a0709e0856b5dd72d108feec9574b0836b4fbf
    Reviewed-on: http://review.couchbase.org/19537
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored August 13, 2012 ingenthr committed August 17, 2012

Aug 13, 2012

  1. Rags

    Adding a getCas() for Store functions

    Change-Id: Ieced868b0b9870838801fd45eee010f61e215fd6
    Reviewed-on: http://review.couchbase.org/19534
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored August 12, 2012 ingenthr committed August 13, 2012

Jul 30, 2012

  1. Matt Ingenthron

    Fixed misc checkstyle errors which crept in.

    Change-Id: I72161b5867b12aa31206a8924f46651cc0566d11
    Reviewed-on: http://review.couchbase.org/19035
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    authored July 30, 2012 ragss committed July 30, 2012
  2. Matt Ingenthron

    Change selection key logging to debug level.

    I was debugging with package net.spy.memcached at the INFO
    level and it was rather annoying seeing these selection key
    messages for each operation.  I believe they should be
    debug level
    
    Change-Id: Ifbb7b619f1e9d85433ff6c7a07ea4cc292737285
    Reviewed-on: http://review.couchbase.org/18996
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored July 28, 2012 mikewied committed July 30, 2012

Jul 25, 2012

  1. Matt Ingenthron

    Revert ErrorCode and OperationStatus changes.

    This is a squashed revert of two separate commits. After
    disabling optimization, I still found failing tests. I had
    thought it was related at first, but after doing a bisect
    it clearly identified the "Create an ErrorCode class" as
    the culprit. In combination with the OperationState
    correctly being volatile, it would regularly fail in the
    midst of bulk operations.
    
    This commit reverts:
    "OperationStatus now has an error code"
     commit cdc26cd and
    "Create an ErrorCode class for error codes"
     commit 82ad6cb.
    
    Change-Id: Id6e04ed1787e140c5072a78cece682c45fe06313
    Reviewed-on: http://review.couchbase.org/18683
    Reviewed-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    Tested-by: Raghavan N. Srinivas <raghavan.srinivas@gmail.com>
    authored July 23, 2012 ragss committed July 25, 2012

Jul 24, 2012

  1. Matt Ingenthron

    Disable optimization by default, remove assert. SPY-88.

    This is only a workaround at the moment for SPY-88, but
    it was found that the addition of the assert with a
    javadoc change and changing OperationState to volatile
    would cause failures in test cases like the
    testParallelSetGet() indicating there is a thread
    safety issue.
    
    While trying to find the specific cause, it seems the best
    approach for now is to disable optimization.
    
    The assert, while correct, is also being disabled since
    it seems to trigger issues with getBulk which seems to
    call the complete() more frequently than it should.
    
    This combination of changes seems to be a tested, stable
    workaround until a proper fix may be implemented.
    
    Change-Id: I755b18aa487247a445657726ae2dc8dad6a27991
    Reviewed-on: http://review.couchbase.org/18670
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored July 21, 2012 ingenthr committed July 24, 2012
  2. Marty Schoch

    add support for TAP request/response with checkpoint info

    Change-Id: If646c70aaa345f3dd1191257dfcedc1aaacdc7b1
    Reviewed-on: http://review.couchbase.org/13571
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored February 23, 2012 ingenthr committed July 24, 2012

Jul 23, 2012

  1. Matt Ingenthron

    Correct test for StringUtils.join().

    Change-Id: I9c320db96a1a1587d39696195f44a1d775cdd0a8
    Reviewed-on: http://review.couchbase.org/18682
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
    Reviewed-by: Michael Nitschinger <michael@nitschinger.at>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored July 23, 2012 ingenthr committed July 23, 2012

Jul 12, 2012

  1. Marty Schoch

    add TAP Opcodes for start/end checkpoint

    Change-Id: Ic90fee141df1485ac55e6fdfc5a922f6a158803b
    Reviewed-on: http://review.couchbase.org/13570
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Reviewed-by: Marty Schoch <marty.schoch@gmail.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored February 23, 2012 mikewied committed July 12, 2012

Jul 11, 2012

  1. Matt Ingenthron

    Let offline try to work with already downloaded mvn.

    Change-Id: I7d41ef0e1781fc1c1f3b3ca01cf07edf5b3d3639
    Reviewed-on: http://review.couchbase.org/17667
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored June 26, 2012 ingenthr committed July 11, 2012
  2. Mike Wiederhold

    JCBC-72: Make OperationException extendable

    This change is needed for a ViewException object in
    Couchbase Client.
    
    Change-Id: I7730bf378e9437d6575d5e9880295a25571d28f6
    Reviewed-on: http://review.couchbase.org/18196
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored July 10, 2012

Jul 03, 2012

  1. Matt Ingenthron

    Comment correction in MemcachedConnection. Non-javadoc.

    Change-Id: Idf5f35739cb286a8e808891a202964ca67e685cf
    Reviewed-on: http://review.couchbase.org/17666
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored June 03, 2012 mikewied committed July 03, 2012

Jun 29, 2012

  1. Mike Wiederhold

    JCBC-52: Fix StringUtils.join()

    This function was implemented incorrectly. It was returning
    a,b,c,
    
    when it should have been returning
    a,b,c
    
    This change fixes this issue.
    
    Change-Id: I822bd3accc2dd2b122b1b44dfe79d8ed36250cf2
    Reviewed-on: http://review.couchbase.org/17027
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored June 10, 2012
  2. Mike Wiederhold

    Fixed parsing of delete tap packet

    We weren't taking the revid into account
    
    Change-Id: Ice82717ada14c7e85b6191470d7174189f878073
    Reviewed-on: http://review.couchbase.org/17640
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored June 26, 2012

Jun 15, 2012

  1. Mike Wiederhold

    SPY-90: getStats() can return an error

    Change-Id: Ida7f9ec4aa101873d464a42db9e5b2b55f2910fa
    Reviewed-on: http://review.couchbase.org/17028
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored June 10, 2012
  2. Mike Wiederhold

    Check if op is null before asserting in OperationFuture

    On another note, the change Matt put in that added this causes
    two other test failures that I didn't have time to fix. I should
    have run make test before pushing his change.
    
    Change-Id: I8bc580f3305191521949a28ce70bca0da8b24d2b
    Reviewed-on: http://review.couchbase.org/17026
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored June 10, 2012

Jun 09, 2012

  1. Matt Ingenthron

    Add javadoc for OperationFuture.

    Change-Id: I9cce09cb58bf8e7ee4afe33f70ec01638b126d85
    Reviewed-on: http://review.couchbase.org/16256
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored May 17, 2012 mikewied committed June 09, 2012
  2. Matt Ingenthron

    Make the OperationState volatile. SPY-88

    Change-Id: Id8a871c018a6a6372367129b8924e5a833f83644
    Reviewed-on: http://review.couchbase.org/16255
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored May 17, 2012 mikewied committed June 09, 2012

Jun 04, 2012

  1. Mike Wiederhold

    OperationStatus now has an error code

    Having error codes will make it easier for users who get errors
    to test for what error it is. Right now we only have the message
    string and this can actually be different for the same error type.
    
    Change-Id: I067e3145d5d95b09d7ca0ad0445bcfa5d5784d51
    Reviewed-on: http://review.couchbase.org/15949
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored May 12, 2012
  2. Mike Wiederhold

    Create an ErrorCode class for error codes

    This allows us to use error codes in other places than just
    operations. This class defines all of the Memcached error codes
    as well as two client specific codes (timed out and canceled). The
    reason for client specific error codes is that is gives the user
    something definitive to test against when error cases happen.
    
    Change-Id: I6b4b21ec8448444103d8e73b440df6085bdc1e33
    Reviewed-on: http://review.couchbase.org/15948
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored May 11, 2012

Jun 02, 2012

  1. Mike Wiederhold

    Fixed tap message test cases

    The flags were wrong here. We were passing a long, but the flag said
    it was an int.
    
    Change-Id: I58af8a9899025fc54db4d374bce6ca5d29b309af
    Reviewed-on: http://review.couchbase.org/15947
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored May 12, 2012 ingenthr committed June 02, 2012

May 24, 2012

  1. Matt Ingenthron

    Make queueReconnect protected so subclasses can request reconnects.

    In fixing JCBC-53 on the Couchbase Java client, a need to queue
    reconnections in some cluster configuration updates was found to be
    required.  This change allows that.
    
    Change-Id: I25ce3945b4e5e6527dd680031237be22faed69ee
    Reviewed-on: http://review.couchbase.org/16335
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored May 22, 2012 mikewied committed May 24, 2012
  2. Matt Ingenthron

    Change vbucket retry logging to debug level. SPY-87

    Change-Id: I31aa045ff6d328858fa44e53720e38b20b8d38dc
    Reviewed-on: http://review.couchbase.org/16257
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    Tested-by: Michael Wiederhold <mike@couchbase.com>
    authored May 21, 2012 mikewied committed May 24, 2012

May 23, 2012

  1. Mike Wiederhold

    Retry not my vbucket error for optimized sets. SPY-88

    Change-Id: I729781636917f80714cf8d9460e4523e876e1258
    Reviewed-on: http://review.couchbase.org/16251
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    authored May 20, 2012 ingenthr committed May 23, 2012

Mar 22, 2012

  1. Matt Ingenthron

    Added toString() for ResponseMessage.

    Change-Id: Ie627cd14631a01a0258d67337251c552e90aa3bc
    Reviewed-on: http://review.couchbase.org/13361
    Reviewed-by: Matt Ingenthron <matt@couchbase.com>
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    authored February 18, 2012 ingenthr committed March 22, 2012

Mar 21, 2012

  1. Matt Ingenthron

    Make log4j, spring-beans optional in our maven artifacts.

    Change-Id: I579a5832fc4ff0ed9d4303c80b309a25dc8cfbaf
    Reviewed-on: http://review.couchbase.org/14159
    Tested-by: Matt Ingenthron <matt@couchbase.com>
    Reviewed-by: Michael Wiederhold <mike@couchbase.com>
    authored March 21, 2012 mikewied committed March 21, 2012
Something went wrong with that request. Please try again.