Symfony's form component cleanup.

[bartlomiej84]

After upgrading to newest version of symfony's master branch, I get following error on forms using this bundle

The form's view data is expected to be of type scalar, array or an instance of \ArrayAccess, 
but is an instance of class Symfony\Component\HttpFoundation\File\File. 
You can avoid this error by setting the "data_class" option 
to "Symfony\Component\HttpFoundation\File\File" or by adding a view 
transformer that transforms Symfony\Component\HttpFoundation\File\File to 
scalar, array or an instance of \ArrayAccess.

Is anyone planning to make PR for this issue ?

[emeraldMaster]

I've got the same problem. I solved it by creating custom dataTransformer like this:

namespace Application\Bundle\DefaultBundle\Form\DataTransformer;

use Symfony\Component\Form\Exception\UnexpectedTypeException;
use Symfony\Component\Form\DataTransformerInterface;

/**
 * VichUploadableFieldType Tranformer
 */
class VichUploadableFieldTransormer implements DataTransformerInterface
{

    /**
     * @param null|FIle $name
     * @return null
     */
    public function transform($name)
    {

        return null;
    }

    /**
     * @param UploadedFile $data
     * @return UploadedFile
     */
    public function reverseTransform($data)
    {

        return $data;
    }
}

it looks ugly ) hope it helps

[bartlomiej84]

The problem seems to appear only for main forms, not child forms.

My solution is:

1. Add to uploader bundle configuration to mapping entry: inject_on_load: false
2. Add property path to form type for image: 'property_path' => 'imageFile'

Ugly too, but working also.

[pixelshaded]

Ive edited my forms by replacing the vich image with something like

->add('image', 'file', array(
'data_class' => 'Symfony\Component\HttpFoundation\File\File',
'property_path' => 'image'
))

[pixelshaded]

I am also getting this error when I leave the image field blank when submitting a form...

Warning: Missing argument 1 for Symfony\Component\HttpFoundation\File\File::__construct(), called in /home/pixelshaded/Projects/Apealz/vendor/symfony/symfony/src/Symfony/Component/Form/Extension/Core/Type/FormType.php on line 158 and defined in /home/pixelshaded/Projects/Apealz/vendor/symfony/symfony/src/Symfony/Component/HttpFoundation/File/File.php line 38

[dustin10]

I am not maintaining this bundle any more so maybe one of you guys can find a solution and submit a PR so that @ftassi can review and merge.

[stfalcon]

:)

[topwebstudio]

An error is being triggered, when using this solution on entity update:

                ->add('image', 'file', array(
                    'data_class' => 'Symfony\Component\HttpFoundation\File\File',
                    'property_path' => 'image',
                    'required' => false,
                ))

#32

[TwistedLogic]

Let the entity is "User" and the property name is "avatar", my solution in form generation was:

$form = $this->createFormBuilder($current_user)
->add('avatar', 'file', array(
'data_class' => 'Symfony\Component\HttpFoundation\File\File'
))
->getForm();

This way the lifecycle callbacks aren't triggered because no change in filename property and no uploaded file gets moved. Because I think second property is useless, I joined the two property as following:

/**
 * @Assert\File(
 *     maxSize="1M",
 *     mimeTypes={"image/png", "image/jpeg", "image/pjpeg"}
 * )
 * @Vich\UploadableField(mapping="user_avatar", fileNameProperty="avatar")
 * @ORM\Column(type="string", length=255)
 *
 * @var File $avatar
 */
protected $avatar;

(fileNameProperty="avatar" is useless, needs refactoring to remove all the logic)
At this point, the upload is working but a wrong url comes out from twig helper. Because we need to get the file name from $avatar instead using $avatar_name, we need a little change to the bundle:

--> Vich\UploaderBundle\Storage\FileSystemStorage#resolvePath line 87;

$mapping->getFileNameProperty()->getValue($obj)->getFilename()

Now everything works. It would be better to remove $filename property and all its logic from the bundle. I will try to fork the bundle to do that, also adding logics for post-upload image processing, and a bundled S3 storage, plus automatic caching policies on filenames for browsers.

Enjoy

[ryall]

Would love to see a fix for this issue. It's affecting the now fully released 2.1.

EDIT: Adding inject_on_load: false seems to have fixed this for me.

[stfalcon]

@dustin10, pls fixed with issue. I again faced with described problem. many time passed, and the bug is still there

[choomz]

@stfalcon @ryall A few months ago, I wanted to use this bundle and I found myself facing the same problem. So I decided to develop mine, you can find it at this address.

[ftassi]

@stfalcon @webkmua Given the PR to Symfony FileType seems to me that the problem is just the missing data_class option, isn't it ?

If that is true then the users affected by this issue should solve by adding the option in their forms, is that right ? At least until the PR is not accepted and merged in Symfony.