Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed improper implementation of content type #501

Merged
merged 4 commits into from Aug 20, 2022

Conversation

blind-intruder
Copy link
Contributor

Add text/plain content type if metadata.ContentType is unable to determine the content type of the file

Add text/plain content type if metadata.ContentType is unable to determine the content type of the file
@@ -1034,6 +1034,11 @@ func (s *Server) getHandler(w http.ResponseWriter, r *http.Request) {

if action == "inline" {
disposition = "inline"
/*
Copy link
Collaborator

@aspacca aspacca Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment does not seem correct :)

Copy link
Collaborator

@aspacca aspacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment @blind-intruder , thanks :)

Copy link
Collaborator

@aspacca aspacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mislooked some datails, please see my updated comment

server/handlers.go Outdated Show resolved Hide resolved
aspacca and others added 3 commits August 20, 2022 13:49
Co-authored-by: Farhan Khursheed <41877347+blind-intruder@users.noreply.github.com>
let's trim space
@aspacca
Copy link
Collaborator

aspacca commented Aug 20, 2022

@blind-intruder , I took the liberty to fix for the linter and add trimming

ready to merge as soon as CI will be green

@aspacca aspacca merged commit 31ad4e0 into dutchcoders:main Aug 20, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants