-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed improper implementation of content type #501
Conversation
Add text/plain content type if metadata.ContentType is unable to determine the content type of the file
| @@ -1034,6 +1034,11 @@ func (s *Server) getHandler(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| if action == "inline" { | |||
| disposition = "inline" | |||
| /* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment does not seem correct :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment @blind-intruder , thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mislooked some datails, please see my updated comment
Co-authored-by: Farhan Khursheed <41877347+blind-intruder@users.noreply.github.com>
let's trim space
|
@blind-intruder , I took the liberty to fix for the linter and add trimming ready to merge as soon as CI will be green |
Add text/plain content type if metadata.ContentType is unable to determine the content type of the file