From 1f4b7f0d14a94a682be09702d70261fdc1a315ae Mon Sep 17 00:00:00 2001 From: mpl Date: Thu, 5 Jan 2023 23:41:48 +0100 Subject: [PATCH] server: do not ignore listening errors --- server/server.go | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/server/server.go b/server/server.go index df5781c1..ca42273e 100644 --- a/server/server.go +++ b/server/server.go @@ -537,32 +537,34 @@ func (s *Server) Run() { ) if !s.TLSListenerOnly { - srvr := &http.Server{ - Addr: s.ListenerString, - Handler: h, - } - listening = true - s.logger.Printf("listening on port: %v\n", s.ListenerString) + s.logger.Printf("starting to listen on: %v\n", s.ListenerString) go func() { - _ = srvr.ListenAndServe() + srvr := &http.Server{ + Addr: s.ListenerString, + Handler: h, + } + + if err := srvr.ListenAndServe(); err != nil { + s.logger.Fatal(err) + } }() } if s.TLSListenerString != "" { listening = true - s.logger.Printf("listening on port: %v\n", s.TLSListenerString) + s.logger.Printf("starting to listen for TLS on: %v\n", s.TLSListenerString) go func() { - s := &http.Server{ + srvr := &http.Server{ Addr: s.TLSListenerString, Handler: h, TLSConfig: s.tlsConfig, } - if err := s.ListenAndServeTLS("", ""); err != nil { - panic(err) + if err := srvr.ListenAndServeTLS("", ""); err != nil { + s.logger.Fatal(err) } }() }