Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach Mode #32

Merged
merged 16 commits into from
Feb 20, 2021
Merged

Reach Mode #32

merged 16 commits into from
Feb 20, 2021

Conversation

dvalters
Copy link
Owner

@dvalters dvalters commented May 6, 2020

Implements reach mode in HAIL-CAESAR

See the issue at #14

Summary

Reach model requires a DEM in the same format as the catchment model/mode. Water will exit from any edge of the DEM, but as per catchment mode, not be routed in NODATA cells.

Reach mode requires an additional file that contains the water and sediment inputs into the catchment. The format of the file is a standard plain text/ascii file.

@dvalters
Copy link
Owner Author

dvalters commented May 7, 2020

Closes #14

@dvalters
Copy link
Owner Author

Reach mode merge

  • No sediment mode has been tested yet but hydro model only mode was working (serial only) with the idealised plane model and the Caersws test case.
  • Simulation quite slow?!
  • The addGS call in the first bit of sediment code caused segfaults, but this can be fixed at later date.
  • Water depth DEMs and Output discarge files looking reasonable.
  • Doesn't quite match outputs from the CL run with the idealised plane slope test case, results diverge quite a bit over time but then this is to be expected as discussed in other issues and via email exchange with Tom C. et al.

To do later

  • Add in OpenMP parallelisation for quick speed up
  • Test sediment routines
  • (Separate sediment routing from hydro routine?)
  • Further testing with Maggie et al.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant