New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix telegram crash when requesting report for invalid addr #318

Merged
merged 1 commit into from Aug 17, 2018

Conversation

2 participants
@jagerman
Contributor

jagerman commented Jul 28, 2018

If attempting to request a report for a miner that doesn't exist on the
pool the telegram bot crashes (data.stats is undefined, leading to an
exception when calling data.stats.hashrate).

This adds a new "not found" error message if the lookup doesn't return
any stats.

Additionally this fixes an error in the event of a harder lookup failure
(e.g. from an error connecting to the api) not using the correct
variable for the recipient.

Fix telegram crash when requesting report for invalid addr
If attempting to request a report for a miner that doesn't exist on the
pool the telegram bot crashes (`data.stats` is undefined, leading to an
exception when calling `data.stats.hashrate`).

This adds a new "not found" error message if the lookup doesn't return
any stats.

Additionally this fixes an error in the event of a harder lookup failure
(e.g. from an error connecting to the api) not using the correct
variable for the recipient.

@dvandal dvandal merged commit 939021c into dvandal:master Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment