add support for multiple illegal characters in heading #33
Conversation
The `sanitizeHeading()` function was using `replace()` with a list of strings, but that only replaces the first instance of each illegal character. This update changes the stockIllegalSymbols to a regExp object with a global flag so that all illegal characters are removed. I don't know how to do the same thing with user defined symbols, so I left that one as it is.
|
See also my comment on the forum: |
But next time I will try to repurpose the "removePreamble" option to ignore shortDate prefix. And the delay (line 53) may help to make default templates work (or maybe templater renaming scripts?)
|
Apologies, my github notifications didn't work correctly and I didn't see this until now. Thanks for the PR I'll review it asap |
|
No problem, thanks for taking a look Oh, it looks like my second commit is included in this pull request. Sorry, I didn't realize it would do that, and my second commit has errors. Ok, I just reverted it. I believe it will work now. Sorry, I'm new to github! |
The last commit had errors and did not effectively introduce anything.
|
The code looks fine to me! I'll give it a test later and get this merged. Can you apply (Even better is if you could add a small unit test, but we don't have unit tests setup in here yet so this might be a bit much |
|
I'm sorry, I don't know either what yarn is nor the CI I googled yarn but I don't think my technical abilities are yet at the point where I can understand it. Is that something I need to do? |
|
No worries, I'll take the PR from here! |
The
sanitizeHeading()function was usingreplace()with a list of strings, but that only replaces the first instance of each illegal character. This update changes the stockIllegalSymbols to a regExp object with a global flag so that all illegal characters are removed. I don't know how to do the same thing with user defined symbols, so I left that one as it is.