Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluidd/Mainsail Download URL Parsing Failure #281

Closed
LongDono opened this issue Jan 6, 2023 · 3 comments · Fixed by #348
Closed

Fluidd/Mainsail Download URL Parsing Failure #281

LongDono opened this issue Jan 6, 2023 · 3 comments · Fixed by #348
Labels
bug Something isn't working

Comments

@LongDono
Copy link

LongDono commented Jan 6, 2023

Linux Distribution

Ubuntu Server 22.04.1 LTS

What happened

The Fluidd download URL parser is failing, preventing installation of Fluidd. I suspect it is because the API limit has been exceeded. I looked through the code and found the URL it was using to try to identify releases and entered it manually:

{"message":"API rate limit exceeded for 38.20.250.13. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}

What did you expect to happen

Download URL to be parsed correctly or if not solvable, a message indicating what the issue is

How to reproduce

Usual installation steps

Additional information

Downloading Fluidd from https://github.com/fluidd-core/fluidd/releases/download//fluidd.zip ...

--2023-01-05 19:45:25-- https://github.com/fluidd-core/fluidd/releases/download//fluidd.zip
Resolving github.com (github.com)... 140.82.112.4
Connecting to github.com (github.com)|140.82.112.4|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2023-01-05 19:45:26 ERROR 404: Not Found.

#=======================================================#
Downloading Fluidd from
https://github.com/fluidd-core/fluidd/releases/download//fluidd.zip
failed!
#=======================================================#

@LongDono LongDono added the bug Something isn't working label Jan 6, 2023
@wilsongis
Copy link

I got the same with both fluidd and mainsail.

@wilsongis
Copy link

I added this to both download functions for mainsail and fluid. It looks like the scripts don't always get the tag for fluidd or mainsail. I am not exactly sure why. I updated my scripts to download a version (current as of today) in cases where it can't find the tag. I rather have something rather than nothing. It is a hack job.

function download_fluidd() {
  local url
  local badurl
  badurl="https://github.com/fluidd-core/fluidd/releases/download//fluidd.zip"
  url=$(get_fluidd_download_url)
  if [ $url==$badurl ]
  then
    url="https://github.com/fluidd-core/fluidd/releases/download/v1.23.1/fluidd.zip"
  else
    url=$(get_fluidd_download_url)
  fi
  status_msg "Downloading Fluidd from ${url} ..."
function download_mainsail() {
  local url
  local badurl
  badurl="https://github.com/mainsail-crew/mainsail/releases/download//mainsail.zip"
  url=$(get_mainsail_download_url)
  if [ $badurl == $url ]
  then
    url="https://github.com/mainsail-crew/mainsail/releases/download/v2.4.1/mainsail.zip"
  else
    url=$(get_mainsail_download_url)
  fi
  status_msg "Downloading Mainsail from ${url} ..."

@LongDono LongDono changed the title Fluidd Download URL Parsing Failure Fluidd/Mainsail Download URL Parsing Failure Feb 14, 2023
@Tron842
Copy link

Tron842 commented Mar 2, 2023

I had the same issue, and it turned out to be the CA store needing to be updated. You can test if you have the same problem by running the following command.

curl "https://api.github.com/repos/mainsail-crew/mainsail/releases/latest"

If you get a 'curl: (60) SSL certificate problem: unable to get local issuer certificate' error, it is probably that. I was able to update my CA store with the following commands:

cd ~
curl "https://curl.se/ca/cacert.pem" -k > cacert.pem
sudo mv ./cacert.pem /usr/local/share/ca-certificates/certificate.crt
sudo dpkg-reconfigure ca-certificates

Hopefully, this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants