New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssh] make TTYs optional #337

Closed
dw opened this Issue Aug 5, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@dw
Owner

dw commented Aug 5, 2018

There is a limit on the maximum number of TTYs many operating systems can allocate. By default on Linux, this is 4096. Given a run targetting more than 4000 machines, TTYs will be easily exhausted, and so using them should be made optional when typing passwords is not necessary.

@dw dw added ssh target:v0.3 labels Aug 5, 2018

@dw

This comment has been minimized.

Show comment
Hide comment
@dw

dw Aug 14, 2018

Owner

Upstream Ansible already supports a flag we can reuse:

      use_tty:
        version_added: '2.5'
        default: 'yes'
        description: add -tt to ssh commands to force tty allocation
        env: [{name: ANSIBLE_SSH_USETTY}]
        ini:
        - {key: usetty, section: ssh_connection}
        type: bool
        vars:
          - name: ansible_ssh_use_tty
            version_added: '2.7'

Triple-check the meaning of it to ensure it means the same thing we want

Owner

dw commented Aug 14, 2018

Upstream Ansible already supports a flag we can reuse:

      use_tty:
        version_added: '2.5'
        default: 'yes'
        description: add -tt to ssh commands to force tty allocation
        env: [{name: ANSIBLE_SSH_USETTY}]
        ini:
        - {key: usetty, section: ssh_connection}
        type: bool
        vars:
          - name: ansible_ssh_use_tty
            version_added: '2.7'

Triple-check the meaning of it to ensure it means the same thing we want

dw added a commit that referenced this issue Sep 7, 2018

dw added a commit that referenced this issue Sep 7, 2018

@dw dw closed this Sep 7, 2018

dw added a commit that referenced this issue Sep 7, 2018

dw added a commit that referenced this issue Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment