New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "doas" become_method #303

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@napkindrawing
Contributor

napkindrawing commented Jul 13, 2018

Howdy!

I've hacked up a first-pass at basic support for the doas become_method, which is working for me on FreeBSD.

I haven't added any unit tests yet, as I'm not familiar with how the tests are laid out here.

Cheers,
Mike

@dw

This comment has been minimized.

Owner

dw commented Jul 13, 2018

Champion! The structure of the connection plug-ins will drastically change for asynchronous connect when that arrives, so right now what you have is perfect -- a little cutpaste it's all I've been doing too :P

Eventually these will be converted to a small set of state machine classes, and the most important thing to capture are the expected strings and general behaviour.

I need to write better stub test implementations for a bunch of stuff, including su, so I will add doas to the list.

Also the "mitogen" Travis jobs are failing right now due to the child process reaping issue -- don't worry about those either.

@dw dw added the NeedsTest label Jul 13, 2018

@napkindrawing

This comment has been minimized.

Contributor

napkindrawing commented Jul 13, 2018

Glorious!

Thanks so much again for all your work with mitogen. It's such an exciting piece of software on it's own, and I still can't believe what a huge impact it will have on ansible 🎉

dw added a commit that referenced this pull request Jul 13, 2018

@dw dw merged commit 745d72b into dw:master Jul 17, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@dw

This comment has been minimized.

Owner

dw commented Jul 17, 2018

Thanks for the PR! It's on master now, I hope to cut another release in the coming week once a few more tickets are closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment