Bugfix: always turn on pygn-mode in PGN-containing temp buffers #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
changed the title
dwcoates
approved these changes
Sep 9, 2021
rolandwalker
deleted the
RW/activate-pygn-mode-in-all-pgn-temp-buffers
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #173, if we create a temp buffer containing PGN data, we must turn on
pygn-modeif we expectpygn-mode-*defuns to be able to work in that buffer.Without the tree-sitter parse tree to refer to, many defuns won't work, or will throw exceptions.
We actually should have noticed this issue back in #154, when the mode was set for the temp buffer in the tests.
Secondarily, as comments note throughout, this whole approach of creating and re-parsing is probably slow, and we should work on redesigning some of these to get the same functionality without temp buffers.