Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magmi – Cross-Site Scripting (XSS) #522

Closed
bestshow opened this issue Mar 18, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@bestshow
Copy link
Contributor

commented Mar 18, 2017

Product: Magmi
Download: https://github.com/dweeves/magmi-git
Vunlerable Version: 0.7.22 and probably prior
Tested Version: 0.7.22
Author: ADLab of Venustech

Advisory Details:
A Cross-Site Scripting (XSS) was discovered in “Magmi 0.7.22”, which can be exploited to execute arbitrary code.
The vulnerability exists due to insufficient filtration of user-supplied data in the “prefix” HTTP GET parameter passed to the “magmi-git-master/magmi/web/ajax_gettime.php” URL. An attacker could execute arbitrary HTML and script code in a browser in the context of the vulnerable website.
The exploitation example below uses the "alert()" JavaScript function to see a pop-up messagebox:
Poc:
http://localhost/.../magmi-git-master/magmi/web/ajax_gettime.php?prefix=%22%3E%3Cscript%3Ealert(1);%3C/script%3E%3C%22

@bestshow

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2017

Excuse me, is there anyone dealing with this issue?

@tmotyl

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2017

@bestshow are you able to prepare a merge request which solves the issue? This would probably speed things up.

@bestshow bestshow closed this Mar 23, 2017

@bestshow

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2017

@tmotyl Yes,I fixed this issue and merge a request,please confirm。

@sreichel

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2017

Hi @bestshow, you merged it into your own master branch, but you should create a PR against this master branch.

@bestshow

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2017

@sreichel Sorry,thank you for pointing out my mistakes,I have created a PR again,please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.