Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magmi – Cross-Site Scripting (XSS) #522

Closed
bestshow opened this issue Mar 18, 2017 · 6 comments · Fixed by #525
Closed

Magmi – Cross-Site Scripting (XSS) #522

bestshow opened this issue Mar 18, 2017 · 6 comments · Fixed by #525

Comments

@bestshow
Copy link
Contributor

bestshow commented Mar 18, 2017

Product: Magmi
Download: https://github.com/dweeves/magmi-git
Vunlerable Version: 0.7.22 and probably prior
Tested Version: 0.7.22
Author: ADLab of Venustech

Advisory Details:
A Cross-Site Scripting (XSS) was discovered in “Magmi 0.7.22”, which can be exploited to execute arbitrary code.
The vulnerability exists due to insufficient filtration of user-supplied data in the “prefix” HTTP GET parameter passed to the “magmi-git-master/magmi/web/ajax_gettime.php” URL. An attacker could execute arbitrary HTML and script code in a browser in the context of the vulnerable website.
The exploitation example below uses the "alert()" JavaScript function to see a pop-up messagebox:
Poc:
http://localhost/.../magmi-git-master/magmi/web/ajax_gettime.php?prefix=%22%3E%3Cscript%3Ealert(1);%3C/script%3E%3C%22

@bestshow
Copy link
Contributor Author

Excuse me, is there anyone dealing with this issue?

@tmotyl
Copy link
Collaborator

tmotyl commented Mar 22, 2017

@bestshow are you able to prepare a merge request which solves the issue? This would probably speed things up.

@bestshow
Copy link
Contributor Author

@tmotyl Yes,I fixed this issue and merge a request,please confirm。

@sreichel
Copy link
Contributor

Hi @bestshow, you merged it into your own master branch, but you should create a PR against this master branch.

@bestshow
Copy link
Contributor Author

@sreichel Sorry,thank you for pointing out my mistakes,I have created a PR again,please check.

@Mohsin07
Copy link

Hi, will the site be secure if we install this plugin in Magento 1.9.x? Please advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants