Fix missing attribute set message #592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"store_website" for general import and "On the fly category creator/importer" plugin - added possibility to create URL rewrites on the fly using plugin "On the fly indexer" - changed allowed Magento version option to "2.1.x"
- disabled checking is attribute configurable - fixed notice in category importer - fixed index in on the fly item procesor - fixed showing indexers list
…e has been tested.
[FEATURE] Improve support of Magento 2.x EE support. Only xcreate mod…
Fixed media path
Fixed a small bug regarding table catalog_product_entity_media_gallery_value_to_entity
Media import folder updated
Update imageitattributeemprocessor.php
Fix in image attribute processor
Fix for duplicated rows in catalog_product_entity_media_gallery_value table
Fix for media gallery issue
This change makes reindex possible. Works for me on the versions of Magento CE 2.1.9 and Magento EE 2.0.0. But in Magento EE 2.0.0 do not create categories and download images from url...
In Magento 2.*.* we have a new two columns - 'tab_group_code', and 'default_group_id'. Without the tab_group_code, no attribute sets are created. These changes allow you to create attribute sets. In the csv file in the column "magmi:groups" we can write for example: attribute_set_name,magmi:groups New_Attribute_Set,"Product Details:product-details,New_Attribute_Set:new-attribute-set,Content:content,Bundle Items:bundle-items,Images:images,Search Engine Optimization:search-engine-optimization,Advanced Pricing:advanced-pricing,Design:design,Schedule Design Update:schedule-design-update,Autosettings:autosettings,Gift Options:gift-options" Additional we can set other parameters in column "magmi:groups" for all attribute groups: "New_Attribute_Set:new-attribute-set:basic:2:1" Where: "New_Attribute_Set" is 'attribute_group_name'; "new-attribute-set" is 'attribute_group_code'; "basic" is 'tab_group_code'; "2" is 'default_group_id'; "1" is 'sort_order'.
When adding configurable products Magmi would throw a error because the magmi code was still checking for the old model eav/entity_attribute_source_table instead of Magento\Eav\Model\Entity\Attribute\Source\Table
Fix for issue #24 use Magento\Eav\Model\Entity\Attribute\Source\Table instead of eav/entity_attribute_source_table
Attribute set import
Reindex did not work.
if ($ovalue !== false && $ovalue != null) returns wrong result in php 5.6.30 and sets $ovalue as false
kudos goes to @bestshow
A value of int(0) was being converted to null. This fixes that error.
The condition currently has an incorrect closing parenthisis which causes the parameter to ini_get to be "false". Also with PHP7 ini_get for the "safe_mode" parameter will return a boolean rather than a string. This patch also contains a condition to handle both cases. Both these issues causes remote CSV file downloads that have redirects (i.e. Dropbox) to always fail.
Division by zero fix
Fix for update image label
Remove unused echo
Use store id when creatng url rewrites
When trying to log in with an established database connection and wrong username, magmi throws an error because $result is empty.
Fixes error " Warning: count(): Parameter must be an array or an object that implements Countable in vendor/macopedia/magmi2/magmi/plugins/extra/itemprocessors/customoptions/pablo_customoptions.php on line 124"
When attributes does not apply to item type or they are missing from attribute set magmi ignores them. Weather this is desired behavior is disputable (for example Magento allows changing attribute set for product without removing attributes data that does not fit, configurable products might work on attributes not in set etc.). I think in such cases at least a warning should be issued to let user know data is beeing lost.
* add warnings when ignoring attributes When attributes does not apply to item type or they are missing from attribute set magmi ignores them. Weather this is desired behavior is disputable (for example Magento allows changing attribute set for product without removing attributes data that does not fit, configurable products might work on attributes not in set etc.). I think in such cases at least a warning should be issued to let user know data is beeing lost. * fix query error on category translation * code formatting Co-authored-by: bertod <bertodattoma@gmail.com>
|
please ignore this accidental PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
throw exception on missing attribute set to improve UX