Skip to content

Fix: oneOfType native check resolution #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2021
Merged

Fix: oneOfType native check resolution #188

merged 1 commit into from
Oct 7, 2021

Conversation

@dwightjack
Copy link
Owner

@dwightjack dwightjack commented Oct 6, 2021 •
edited
Loading

This PR fixes a bug introduced in 6811079 that causes the nativeChecks array to contain instances of validators in the following scenario:

oneOfType([number(), string()])

Expected
image

Result
image

It should fix #187.

@dwightjack dwightjack self-assigned this Oct 6, 2021
@dwightjack dwightjack marked this pull request as ready for review October 6, 2021 12:12
@dwightjack dwightjack merged commit 7e20670 into next Oct 7, 2021
@dwightjack dwightjack deleted the fix/oneoftype branch July 23, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dwightjack dwightjack

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

using .def() with oneOfType throws error

2 participants

@dwightjack