Fixed memory leak. Closes #4.

dwmkerr · Feb 27, 2015 · 79998ca · 79998ca
1 parent 73a28ab
commit 79998ca
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## v0.6.3
+
+* Fixed memory leak.
+
 ## v0.6.2
 
 * Tidied up logic for cleanup.

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-modal-service",
-  "version": "0.6.2",
+  "version": "0.6.3",
   "homepage": "https://github.com/dwmkerr/angular-modal-service",
   "authors": [
     "Dave Kerr (github.com/dwmkerr)"

diff --git a/dst/angular-modal-service.js b/dst/angular-modal-service.js
@@ -94,6 +94,17 @@
                   //  We can now clean up the scope and remove the element from the DOM.
                   modalScope.$destroy();
                   modalElement.remove();
+
+                  //  Unless we null out all of these objects we seem to suffer
+                  //  from memory leaks, if anyone can explain why then I'd 
+                  //  be very interested to know.
+                  inputs.close = null;
+                  deferred = null;
+                  closeDeferred = null;
+                  modal = null;
+                  inputs = null;
+                  modalElement = null;
+                  modalScope = null;
                 }, delay);
               }
             };

diff --git a/dst/angular-modal-service.min.js b/dst/angular-modal-service.min.js