New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled template directory #58

Closed
ghost3k opened this Issue Jan 14, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@ghost3k

ghost3k commented Jan 14, 2017

Upgraded from Dwoo 1.2.0 to 1.3.3. It seems the compile directory is no longer used, and the compiled template files are placed in the same directory as the source template. Is this by design?
Using setCompileDir() does nothing now.

I fixed it back by changing lib/Dwoo/Template/File.php, function getCompiledFilename:
old line:
return $this->compileId . '.d' . Core::RELEASE_TAG . '.php';
my fixed line:
return $core->getCompileDir() . $this->compileId . '.d' . Core::RELEASE_TAG . '.php';

This was the initial line, but was changed in a commit on Sep 22, 2016.

Thanks!

@emulienfou emulienfou self-assigned this Jan 14, 2017

@emulienfou emulienfou added the bug label Jan 14, 2017

@emulienfou emulienfou added this to the 1.3.4 milestone Jan 14, 2017

@emulienfou

This comment has been minimized.

Show comment
Hide comment
@emulienfou

emulienfou Jan 17, 2017

Contributor

Hi! I'm aware about this bug, this change was made because using {include} function who generated an error.
However my fix was not a good idea!
Trying to do a better fix ASAP.

Contributor

emulienfou commented Jan 17, 2017

Hi! I'm aware about this bug, this change was made because using {include} function who generated an error.
However my fix was not a good idea!
Trying to do a better fix ASAP.

@creativecat

This comment has been minimized.

Show comment
Hide comment
@creativecat

creativecat Jan 21, 2017

Thank you... I was searching for fixing exactly this bug... works fine for me :-)

Thank you... I was searching for fixing exactly this bug... works fine for me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment