From 672e8c36c2e09682954c21528fb1e48e59f1d6f7 Mon Sep 17 00:00:00 2001 From: Justen Barget Date: Mon, 21 Nov 2016 11:54:35 +0000 Subject: [PATCH 1/3] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a1f823a..a533318 100644 --- a/README.md +++ b/README.md @@ -239,7 +239,7 @@ https://www.nngroup.com/articles/legibility-readability-comprehension/ When you see someone _trying_ to use ***all*** the ***latest features*** of **ECMAScript 2015**, -its clear they are just trying to *look* smart to their piers +its clear they are just trying to *look* smart to their peers and have not stopped to think/ask: + "_will this code **work everywhere**_?" + "_did the **users** ask me to use this (new) language feature_? From 6270923835db4a31c5028a5f10bec20fd63efbdd Mon Sep 17 00:00:00 2001 From: Justen Barget Date: Wed, 23 Nov 2016 11:16:18 +0000 Subject: [PATCH 2/3] Adding es6 rule as per discussion https://github.com/dwyl/goodparts/pull/276#issuecomment-262470420 --- rules/es6.js | 1 + 1 file changed, 1 insertion(+) diff --git a/rules/es6.js b/rules/es6.js index e1de346..b537872 100644 --- a/rules/es6.js +++ b/rules/es6.js @@ -13,6 +13,7 @@ module.exports = { 'no-duplicate-imports': 'off', 'no-new-symbol': 'off', 'no-restricted-imports': 'off', + 'no-return-await': 'off', // https://github.com/dwyl/goodparts/issues/274 'no-this-before-super': 'off', 'no-useless-computed-key': 'off', 'no-useless-constructor': 'off', From dc8b70a1a925aef813caeaaccb6b6bb59a014028 Mon Sep 17 00:00:00 2001 From: Justen Barget Date: Wed, 23 Nov 2016 11:17:10 +0000 Subject: [PATCH 3/3] adding test rule as per discussion https://github.com/dwyl/goodparts/pull/276#issuecomment-262470420 --- test/fixtures/es6.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/fixtures/es6.js b/test/fixtures/es6.js index 7f8e56c..ae9db4a 100644 --- a/test/fixtures/es6.js +++ b/test/fixtures/es6.js @@ -13,6 +13,7 @@ module.exports = { 'no-duplicate-imports': null, 'no-new-symbol': null, 'no-restricted-imports': null, + 'no-return-await': null, 'no-this-before-super': null, 'no-useless-computed-key': null, 'no-useless-constructor': null,