-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: tags
page with tons more detail
#396
Comments
hey everyone! Do you think this is ready to be developed? I can take it :D |
@panoramix360 go for it. π |
hey! I began the task :D I was looking through the tags structure, and it seems it's not a LiveComponent, do you think we will need to transform it to a LiveComponent so we can make the sorting work? I think we need to hehe, let me know what you guys think! |
Please go ahead. Thanks. π |
@panoramix360 looks amazing π Thank you so much for your contributions, they're very much super appreciated! |
Draft PR created so you guys can begin the review πΊ I have to add the tests for the new screen π I have one problem that I want to ask for your help with so we can see how we can solve it. I was able to build the sorting mechanism in the query, but it's not working with the virtual/calculated fields, I tried some stuff but only could make it work if I wrote hardcoded, but it does not work dynamically. Do you have any idea what we could do? I'm thinking that maybe we will need to rewrite the query using Ecto Macros for it to work. |
Hard-coded is already a good start.
|
understood, but I think this probably should be an issue by itself, no? Maybe just for now, I could sort using Elixir in the context of the LiveView (not using Ecto), what do you think? I think that sorting by some library could be changed on a different PR. |
Yeah, we can have a separate issue on sortable tables using a JS library. π |
Dedicated (separate) issue for the sorting/filtering: #436 |
Probably this Issue could be solved after the PR merged :D |
Closing this off since #435 was merged :) |
As noted by @panoramix360 in #140 (comment) π¬
![mvp-nelson-tags](https://private-user-images.githubusercontent.com/194400/254181409-098cfae2-aab8-4517-8c22-edae919847dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUwOTQ2ODAsIm5iZiI6MTcyNTA5NDM4MCwicGF0aCI6Ii8xOTQ0MDAvMjU0MTgxNDA5LTA5OGNmYWUyLWFhYjgtNDUxNy04YzIyLWVkYWU5MTk4NDdkZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODMxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgzMVQwODUzMDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YjUwMmQwM2Q1OWNkZGYyNDhlZjA4OTkwNjg1MmJjNTdhZDg0MDBmYWUyNWZiY2YwMjhkZTlhNDk4Y2ZiYWRiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.PfEvO-P17Ajbr_goWP_8VcMQy3OG6cD_9QJphqISjs0)
At present the
/tags
page is quite basic: https://mvp.fly.dev/tags this is my tags page:I have
118
tags
at the time of writing:Some of these are duplicates and there are a few typos. π€¦ββοΈ
So in an ideal world, we'd also have a way of "merging"
tags
. πBut I suspect I'm the only
person
withthis
"problem" right now. πSo let's just focus on adding useful details to this page
before
doing anything "fancy" ... πTodo
/tags
page to include a lot more info in a sortable table.Columns:
tag.text
- the "pill" of thetag
with thetag.color
applied (the current appearance, see above)tag.color
- thehex
code for thetag.color
- ideally clicking/tapping on this will open the color picker.created_at
- when thetag
was createdlatest
- the last time anitem
was tagged with thistag
.items
count
- the of the number ofitems
with thistag
- clicking/tapping on the count will take you back to theitems
view with with thefilter=tag_name
so that you are seeing theitems
with thattag
applied.time
- the total time that has been logged onitems
with thistag
edit
- the edit button for editingdelete
- delete thetag
(though I'm not a fan of this permanent destruction ...)This is a perfect opportunity to make this a look good by using
![image](https://private-user-images.githubusercontent.com/194400/254182445-dfe2cfd9-d110-4e96-ac89-153d47b71b7d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUwOTQ2ODAsIm5iZiI6MTcyNTA5NDM4MCwicGF0aCI6Ii8xOTQ0MDAvMjU0MTgyNDQ1LWRmZTJjZmQ5LWQxMTAtNGU5Ni1hYzg5LTE1M2Q0N2I3MWI3ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODMxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgzMVQwODUzMDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kYjQ3MWRmMmUyNzE3NTU5YTcyNDMyOGQ5NWM5MDRmYTlkZjdlZTIzMzg0MjEyYWUxOWM2NjY1MTg2ZGY1NmRlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.dtVJoKkh7DzY6YYmphEn-OCthRpKXcpyX3z7uXIwVdU)
Tailwind UI -> With sortable headings
:https://tailwindui.com/components/application-ui/lists/tables#component-7b5a46e74e475708d966ca31716f1771
The text was updated successfully, but these errors were encountered: