From da0a7579647bdc8b6c467f74df10d112e6e1fb64 Mon Sep 17 00:00:00 2001 From: R6736 Date: Tue, 27 Jun 2023 20:43:27 +0200 Subject: [PATCH] fix(picklist): fix org response and exclude custom metadata picklists --- .../src/package/deploymentCustomizers/PicklistEnabler.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/core/src/package/deploymentCustomizers/PicklistEnabler.ts b/packages/core/src/package/deploymentCustomizers/PicklistEnabler.ts index 284a54ba1..772a2d977 100644 --- a/packages/core/src/package/deploymentCustomizers/PicklistEnabler.ts +++ b/packages/core/src/package/deploymentCustomizers/PicklistEnabler.ts @@ -58,6 +58,8 @@ export default class PicklistEnabler implements DeploymentCustomizer { if (!customField || customField['type'] !== 'Picklist' || !customField.valueSet?.valueSetDefinition) { continue; } + //no updates for custom metadata picklists + if(customField['fieldManageability']) continue; let objName = fieldComponent.parent.fullName; let picklistName = fieldComponent.name; @@ -78,7 +80,7 @@ export default class PicklistEnabler implements DeploymentCustomizer { for (const value of picklistInOrg.Metadata.valueSet.valueSetDefinition.value) { - if (value.isActive == false) { + if (value.isActive == 'false') { continue; } @@ -115,7 +117,7 @@ export default class PicklistEnabler implements DeploymentCustomizer { let response = await QueryHelper.query(urlId, conn, true); - if (response) { + if (response && Array.isArray(response) && response.length > 0 && response[0].attributes) { let responseUrl = response[0].attributes.url; let fieldId = responseUrl.slice(responseUrl.lastIndexOf('.') + 1); let responsePicklist = await conn.tooling.sobject('CustomField').find({ Id: fieldId });