Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Interaction design page “colour-and-contrast” #20

Merged
merged 4 commits into from Feb 17, 2023

Conversation

mingoland
Copy link
Collaborator

Automatically generated by Netlify CMS

@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for calm-klepon-bae648 ready!

Name Link
🔨 Latest commit cd6979e
🔍 Latest deploy log https://app.netlify.com/sites/calm-klepon-bae648/deploys/63ea7aec63815c00082b5079
😎 Deploy Preview https://deploy-preview-20--calm-klepon-bae648.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for startling-pasca-a7e8b4 ready!

Name Link
🔨 Latest commit cd6979e
🔍 Latest deploy log https://app.netlify.com/sites/startling-pasca-a7e8b4/deploys/63ea7aece28ad400086e7a34
😎 Deploy Preview https://deploy-preview-20--startling-pasca-a7e8b4.netlify.app/interaction-design/colour-and-contrast
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@yndajas yndajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change so happy to approve. Just one comment about formatting

Comment on lines 48 to 58
[Guideline 1.4.3 – Contrast (Minimum)](https://www.w3.org/WAI/WCAG21/quickref/#contrast-minimum)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between heading and content

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again @yndajas thanks for spotting it. Let me correct them. And once again it shows that we may need someone or even a content designer to review the general style and tones. Let's iterate all these things bit by bit.

CC-ing @calumryan as well so he knows the concerns.

@mingoland mingoland force-pushed the cms/interaction-design/colour-and-contrast branch from 5d03d60 to 61712d8 Compare February 13, 2023 17:50
@mingoland mingoland merged commit 6bb3c55 into main Feb 17, 2023
11 checks passed
@yndajas yndajas deleted the cms/interaction-design/colour-and-contrast branch March 16, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants