Fix media folder #26
Merged
Fix media folder #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After re-enabling image uploads in 4c236aa, images were successfully uploaded but they went into a project root `/_images` folder, which appears not to be included in the Jekyll build. Links to images are not working in production This updates the media folder to `src/assets/images`. `src/assets` is a more standard place to store images (and stylesheets), and files placed there are already included in the build This works locally without `src/` included, so the hope is that like for `file` and `folder` Netlify config attributes, including it with `src/` will work in production
✅ Deploy Preview for startling-pasca-a7e8b4 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for calm-klepon-bae648 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
calumryan
approved these changes
Feb 22, 2023
yndajas
added a commit
to dxw/playbook
that referenced
this pull request
Feb 27, 2023
This removes the config setting disabling image uploads and sets the upload folder to `/assets/images`, which is automatically include in the compiled site Based on: - dxw/accessibility-manual#21 - dxw/accessibility-manual#26
yndajas
added a commit
to dxw/playbook
that referenced
this pull request
Feb 27, 2023
This brings the existing image assets more in line with the structure in use for Netlify CMS image uploads I've moved all the favicon-related images and other files into a dedicated subfolder to make them easier to distinguish (and make it clearer what they're related to) Based on: dxw/accessibility-manual#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After re-enabling image uploads in 4c236aa, images were successfully uploaded but they went into a project root
/_imagesfolder, which appears not to be included in the Jekyll build. Links to images are not working in productionThis updates the media folder to
src/assets/images.src/assetsis a more standard place to store images (and stylesheets), and files placed there are already included in the buildThis works locally without
src/included, so the hope is that like forfileandfolderNetlify config attributes, including it withsrc/will work in productionThis also shifts existing images into
src/assets/images