Add headings from within block groups to in-page navigation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, only headings in the root of the page were found - This update recurses into block groups to find headings there Technically: - Creates a recursive findHeadingBlocks() function to walk through the blocks looking for headings - This needs a class-level storage of the found headings in inPageNavItems array - Moves the parsing of the heading object for the nav into a callable parseHeading() function - Refactors main getItems() method to use the above - Specifically, this is wanted for lambethtogether.net -- E.g. https://lambethtogether.net/long-read/nwda-report/thriving-communities/ should have the 'Context and key challenges' in the in-page navigation - To test, copy the above long-read or create a long read and group blocks with a heading included - Resolves: https://dxw.zendesk.com/agent/tickets/17292 / https://dxw.zendesk.com/agent/tickets/17261
brent-dxw
force-pushed
the
fix/longread-page-navigation
branch
from
a29d17a
to
2fe08b0
Compare
RobjS
previously requested changes
Dec 14, 2022
There was a problem hiding this comment.
@brent-dxw Haven't tested locally yet, but the changes generally look good and make sense 👍 The InPageNavigation class has some tests it'd be good to update to reflect these changes, though.
@RobjS Thanks - I've added a test for that |
calumryan
approved these changes
Dec 21, 2022
brent-dxw
dismissed
RobjS’s stale review
This has been implemented and approved in rob's absence, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only headings in the root of the page were found
This update recurses into block groups to find headings there
Specifically, this is wanted for lambethtogether.net -- E.g. https://lambethtogether.net/long-read/nwda-report/thriving-communities/ should have the 'Context and key challenges' in the in-page navigation
To test, copy the above long-read or create a long read and group blocks with a heading included
Resolves: https://dxw.zendesk.com/agent/tickets/17292 / https://dxw.zendesk.com/agent/tickets/17261
Due to the nature of the dependencies for the changes, it is included in one commit. Technically this implements: