Permalink
Commits on Oct 21, 2018
  1. Pass Vclip as context

    vLKp committed Oct 21, 2018
  2. Add fwd-vclip.h

    vLKp committed Oct 21, 2018
  3. Adjust release note about ADL MIDI support

    vLKp committed Oct 21, 2018
    "adlmidi"[1] and "libADLMIDI"[2] are different projects.  Only the latter is
    targeted by the contributed feature.  Adjust the release note to use the
    name of the latter instead of letting readers guess which project is
    intended.
    
    [1]: https://github.com/bisqwit/adlmidi
    [2]: https://github.com/Wohlstand/libADLMIDI
    
    Reported-by: Wohlstand <#407 (comment)>
    Fixes: a764874 ("Make ADL MIDI runtime configurable")
Commits on Oct 20, 2018
  1. Remove explicit std::move in prepare_mission_menu_state return

    vLKp committed Oct 20, 2018
    clang warns that this interferes with copy elision.  The generated code
    is slightly worse after following clang's advice and removing this, but
    this is not a hot path, so take the hit to silence clang instead of
    complicating the source.
    
    Fixes: d97afc2 ("Retain directory structure in New Game dialog")
  2. Fix gcc-4.9 build of similar/main/net_udp.cpp

    vLKp committed Oct 20, 2018
    gcc-4.9 std::array::size() is `constexpr`, but gcc-4.9 refuses to
    initialize a local `constexpr std::size_t` from the result of calling
    `size()` on a `std::array`.  Later gcc permit this.  gcc-8 generates the
    same code whether the variable is `constexpr std::size_t` or `const
    std::size_t`, and the latter allows gcc-4.9 to build, so remove
    `constexpr` and use plain `const`.
    
    Reported-by: joolswills <#411>
    Fixes: 91d6285 ("Factor out shortening game/mission names")
  3. Fix gcc-4.9 build of similar/main/wall.cpp

    vLKp committed Oct 20, 2018
    gcc-4.9 shipped without support for std::is_trivially_move_assignable.
    This is only needed in a sanity check, so preprocess it out when using a
    gcc below gcc-5.
    
    Reported-by: joolswills <#411>
    Fixes: 5733425 ("Simplify stuck object cleanup")
  4. Fix clang warning about using %hu with unsigned

    vLKp committed Oct 20, 2018
    gcc permits this, but clang complains.  Match the format specifier to
    the type of the underlying temporary variable.
    
    Fixes: a65068f ("Move OGL RLE bitmap buffer to stack")
Commits on Oct 18, 2018
  1. Merge branch experimental/adlmidi into master

    vLKp committed Oct 18, 2018
    Add experimental support for using ADL MIDI instead of SDL for music
    playback.  Support for ADL MIDI contributed by Github user jpcima.  This
    feature is minimally supported by the core Rebirth team, but is included
    as a courtesy so that users need not patch in support separately.
    
    Suggested-by: jpcima <#408>
  2. Make ADL MIDI runtime configurable

    vLKp committed Oct 18, 2018
    Add configuration file entries for number of chips, bank index, and
    whether to use ADL MIDI.  Currently, there is no GUI for this.
    Interested users must enable it via direct configuration file editing.
    A menu interface will come later.
Commits on Oct 15, 2018
  1. Add build time flag to choose whether to enable ADL MIDI support

    vLKp committed Oct 15, 2018
    Since ADL MIDI is not packaged on some distributions, default the option
    to off.
  2. Rework ADL dynamic loader

    vLKp committed Oct 15, 2018
    - Use the Windows type `HMODULE` on Windows, and define a local alias to
      it on non-Windows.  This makes the code slightly clearer about the
      nature of the value `handle`.
    - Move the `dlopen` emulation into the anonymous namespace to encourage
      inlining, since the wrappers are trivial name/signature compatibility
      functions.
    - Move the error reporting out of the template function, so that it is
      not redundantly instantiated for each type used with the template.
  3. Remove explicit `=nullptr` in ADL function pointers

    vLKp committed Oct 15, 2018
    Global data will default to nullptr, so the initialization is
    unnecessary.  Some compilers may store the pointer in `.data` when it is
    initialized to any value.
  4. Remove unused adl_openBankFile

    vLKp committed Oct 15, 2018
Commits on Oct 10, 2018
  1. Fix crash after pausing movie

    vLKp committed Oct 10, 2018
    The movie code assumes that when the topmost window is closed, that
    window must have been the movie window, and that the movie data can now
    be freed.  However, if the movie is paused, a new topmost window is
    created to tell the user that the movie is paused.  When that topmost
    pause window is deleted, the movie code frees the movie data, even
    though the movie is not done.  Corruption ensues, ultimately leading to
    a crash.
    
    Reported-by: Jayman2000 <#410>
Commits on Oct 8, 2018
  1. Vary marker spin

    vLKp committed Oct 8, 2018
  2. Pass context to set_powerup_id

    vLKp committed Oct 8, 2018
Commits on Oct 1, 2018
  1. Fix truecolor handling in mve playback

    vLKp committed Oct 1, 2018
    This has been broken for more than 5 years and no one reported it.
    Perhaps truecolor movies are not used.
    
    Fixes: acb664a ("Use proper type for mve backbuffers")
Commits on Sep 25, 2018
  1. Make `Viewer` `const object *`

    vLKp committed Sep 25, 2018
    Viewing should not change anything.
Commits on Sep 22, 2018
Commits on Sep 19, 2018
  1. Pass segments to find_point_seg

    vLKp committed Sep 19, 2018