This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Orders fee to a percentage rather than an absolute price amount #137

Closed

3 tasks

BrendanChou opened this issue Apr 7, 2020 · 0 comments · Fixed by #138

Closed

3 tasks

Orders fee to a percentage rather than an absolute price amount #137

BrendanChou opened this issue Apr 7, 2020 · 0 comments · Fixed by #138

Assignees

Labels

P1

Contributor

BrendanChou commented Apr 7, 2020 •

edited

Loading

https://github.com/dydxprotocol/solo/blob/master/contracts/external/traders/CanonicalOrders.sol#L712

Fix Collateralization check in Orders.ts
Fix smart contract
Fix tests

BrendanChou added the P1 label

BrendanChou assigned Kenadia

Kenadia mentioned this issue

Represent fee as a percentage of price #138

Merged

Kenadia closed this as completed in #138

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.