Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various spelling errors #225

Merged
merged 2 commits into from Apr 8, 2019

Conversation

@BrendanChou
Copy link
Contributor

commented Apr 6, 2019

Fixes #224

@BrendanChou BrendanChou requested a review from AntonioJuliano Apr 6, 2019

@@ -182,7 +182,7 @@ describe('PolynomialInterestSetter', () => {
expect(maxAPR2).toEqual(newAPR);
});

it('Fails to deploy contracts whose coefficients dont add to 100', async () => {
it('Fails to deploy contracts whose coefficients don\'t add to 100', async () => {

This comment has been minimized.

Copy link
@AntonioJuliano

AntonioJuliano Apr 8, 2019

Member

this is going to be annoying if you can't just crtl + f the test name (that's what I always do)

Either use ` or " or keep as is

@BrendanChou BrendanChou force-pushed the spelling branch from 3fac979 to 3769e92 Apr 8, 2019

@BrendanChou BrendanChou merged commit 93386e0 into master Apr 8, 2019

7 checks passed

ci/circleci: build_contracts Your tests passed on CircleCI!
Details
ci/circleci: build_js Your tests passed on CircleCI!
Details
ci/circleci: checkout_and_install Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@BrendanChou BrendanChou deleted the spelling branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.