From b9288223b5ef1f1f23d781744888add82e18f8a6 Mon Sep 17 00:00:00 2001 From: Brendan Chou Date: Fri, 5 Apr 2019 17:13:27 -0700 Subject: [PATCH 1/2] fix various spelling errors --- __tests__/PolynomialInterestSetter.test.ts | 2 +- contracts/external/oracles/DaiPriceOracle.sol | 2 +- contracts/external/proxies/PayableProxyForSoloMargin.sol | 2 +- contracts/protocol/SoloMargin.sol | 2 +- contracts/protocol/interfaces/IErc20.sol | 2 +- contracts/protocol/lib/Token.sol | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/__tests__/PolynomialInterestSetter.test.ts b/__tests__/PolynomialInterestSetter.test.ts index eff431e2..07179048 100644 --- a/__tests__/PolynomialInterestSetter.test.ts +++ b/__tests__/PolynomialInterestSetter.test.ts @@ -182,7 +182,7 @@ describe('PolynomialInterestSetter', () => { expect(maxAPR2).toEqual(newAPR); }); - it('Fails to deploy contracts whose coefficients dont add to 100', async () => { + it('Fails to deploy contracts whose coefficients don\'t add to 100', async () => { await expectThrow( solo.contracts.testPolynomialInterestSetter.methods.createNew({ maxAPR: '0', diff --git a/contracts/external/oracles/DaiPriceOracle.sol b/contracts/external/oracles/DaiPriceOracle.sol index a36a0d5f..0420aabb 100644 --- a/contracts/external/oracles/DaiPriceOracle.sol +++ b/contracts/external/oracles/DaiPriceOracle.sol @@ -189,7 +189,7 @@ contract DaiPriceOracle is /** * Gets the USD price of DAI that this contract will move towards when updated. This price is - * not bounded by the varaibles governing the maximum deviation from the old price. + * not bounded by the variables governing the maximum deviation from the old price. */ function getTargetPrice() public diff --git a/contracts/external/proxies/PayableProxyForSoloMargin.sol b/contracts/external/proxies/PayableProxyForSoloMargin.sol index bac509f7..fc062dd8 100644 --- a/contracts/external/proxies/PayableProxyForSoloMargin.sol +++ b/contracts/external/proxies/PayableProxyForSoloMargin.sol @@ -71,7 +71,7 @@ contract PayableProxyForSoloMargin is { require( // coverage-disable-line msg.sender == address(WETH), - "Cannot recieve ETH" + "Cannot receive ETH" ); } diff --git a/contracts/protocol/SoloMargin.sol b/contracts/protocol/SoloMargin.sol index 8a340932..13ebdf4e 100644 --- a/contracts/protocol/SoloMargin.sol +++ b/contracts/protocol/SoloMargin.sol @@ -31,7 +31,7 @@ import { Storage } from "./lib/Storage.sol"; * @title SoloMargin * @author dYdX * - * Main contract that inherets from other contracts + * Main contract that inherits from other contracts */ contract SoloMargin is State, diff --git a/contracts/protocol/interfaces/IErc20.sol b/contracts/protocol/interfaces/IErc20.sol index 0b76cff5..7fcba569 100644 --- a/contracts/protocol/interfaces/IErc20.sol +++ b/contracts/protocol/interfaces/IErc20.sol @@ -23,7 +23,7 @@ pragma solidity 0.5.7; * @author dYdX * * Interface for using ERC20 Tokens. We have to use a special interface to call ERC20 functions so - * that we dont automatically revert when calling non-compliant tokens that have no return value for + * that we don't automatically revert when calling non-compliant tokens that have no return value for * transfer(), transferFrom(), or approve(). */ interface IErc20 { diff --git a/contracts/protocol/lib/Token.sol b/contracts/protocol/lib/Token.sol index c4377331..f342c418 100644 --- a/contracts/protocol/lib/Token.sol +++ b/contracts/protocol/lib/Token.sol @@ -164,7 +164,7 @@ library Token { returnValue := mload(0x0) } - // not sure what was returned: dont mark as success + // not sure what was returned: don't mark as success default { } } From 3769e925791b18edfbf2afe0aac5d6598f2f4ab2 Mon Sep 17 00:00:00 2001 From: Brendan Chou Date: Mon, 8 Apr 2019 11:04:25 -0700 Subject: [PATCH 2/2] make test name searchable --- __tests__/PolynomialInterestSetter.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/__tests__/PolynomialInterestSetter.test.ts b/__tests__/PolynomialInterestSetter.test.ts index 07179048..f5acbaf6 100644 --- a/__tests__/PolynomialInterestSetter.test.ts +++ b/__tests__/PolynomialInterestSetter.test.ts @@ -182,7 +182,7 @@ describe('PolynomialInterestSetter', () => { expect(maxAPR2).toEqual(newAPR); }); - it('Fails to deploy contracts whose coefficients don\'t add to 100', async () => { + it("Fails to deploy contracts whose coefficients don't add to 100", async () => { await expectThrow( solo.contracts.testPolynomialInterestSetter.methods.createNew({ maxAPR: '0',