Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clarifying comments #233

Merged
merged 1 commit into from Apr 12, 2019

Conversation

@BrendanChou
Copy link
Contributor

commented Apr 11, 2019

Fixes #201 by adding comments where necessary to make things more clear, but does not change code.

Adding constants at the top of the file may increase code bloat and make things less clear than just adding comments.

Also at this stage, it is risky to change code even if just changing hard-coded values to use constants.

@BrendanChou BrendanChou merged commit a6f09f1 into master Apr 12, 2019

7 checks passed

ci/circleci: build_contracts Your tests passed on CircleCI!
Details
ci/circleci: build_js Your tests passed on CircleCI!
Details
ci/circleci: checkout_and_install Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
coverage/coveralls First build on bc_constants at 100.0%
Details

@BrendanChou BrendanChou deleted the bc_constants branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.